-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for randomized sampling #181
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
fc36b9d
Update kp_sampler_skip.cpp
vlkale a18b328
Merge branch 'develop' into allow-randomized-sampling
vlkale abafd7a
update to Makefile
vlkale 3bede60
putting in fix to sampler skip with randomized probabilities
vlkale a0a1bd2
Merging kp_sampler_skip.cpp with fixes
vlkale 7d2302d
committing sampler formatted file
vlkale 5e4f762
putting fixes for formatting into kp_sampler skip
vlkale 6269ab4
fixed kp_sampler making tool_prob_num an int
vlkale c7c724c
committed formatted sampler_skip.cpp
vlkale 9830c58
fixing randomized samples to obtain correct invocation number.
vlkale 4e5c4a4
Update kp_sampler_skip.cpp
vlkale d7aa5bc
Applied clang-format-8
3254951
committing kp sampler with fix to scan
vlkale f236b87
coommitting delete commented code
vlkale c05a65f
fix kp sampler skip formatting
vlkale 79ebc63
fix to randomization float conversation and clang-formatting
vlkale 75b23d7
Readme
vlkale cf105ff
Fix tool glob fence to bool
vlkale a9cb706
set new defaults of tool prob num and kernelSampleSkip
vlkale 5db6e8c
Error check and handle case when both skip rate and probability set
vlkale 278bfe0
fixing the sampler's minimum skip rate so it is zero in order fix err…
vlkale 687bdd2
fixing the sampler's nestedkID init in parallel reduce
vlkale b606098
putting numeric limits for kernelSampleSkip back in
vlkale 82b2423
applied clang format
vlkale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
CXX = clang++ | ||
CXX = g++ | ||
|
||
CXXFLAGS = -O3 -std=c++17 -g | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
This is a sampler utility that is intended to complement other tools in the Kokkos Tools set. This utility allows for sampling (rather than collecting) of profiling or debugging data gathered from a particular tool of the Kokkos Tools set. The Kokkos Tools user provides a sampling rate via the environment variable KOKKOS_TOOLS_SAMPLER_SKIP. | ||
This is a sampler utility that is intended to complement other tools in the Kokkos Tools set. This utility allows for sampling (rather than collecting) of profiling or debugging data gathered from a particular tool of the Kokkos Tools set. The Kokkos Tools user provides a sampling rate via the environment variable KOKKOS_TOOLS_SAMPLER_SKIP. It also has an environment variable for sampling probability, KOKKOS_TOOLS_SAMPLER_PROBABILITY that is a percent, taken as a float, between 0.0 and 100.0. | ||
|
||
In order for the state of the sampled profiling and logging data in memory to be captured at the time of the utility's callback invocation, it might be important to enforce fences. However, this also means that there are more synchronization points compared with running the program without the tool. | ||
This fencing behavior can be controlled by setting the environment variable `KOKKOS_TOOLS_GLOBALFENCES`. A non-zero value implies global fences on invocation of the tool. The default is not to introduce extra fences. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both tool_prob_num < 0 and kernelSampleSkip is max of uint64_t set tool_prob_num to 10.0
Make an error check checking that not. both of them are set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
tool_prob_num
default has been assigned to the default requested. ThekernelSampleSkip
default is part of a new PR which focuses just on the correct matching of sampled kernels.