Improvements thanks to review.

kokkos · Nov 17, 2023 · 05dfaef · 05dfaef
1 parent c390533
commit 05dfaef
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/profiling/nvtx-connector/Makefile b/profiling/nvtx-connector/Makefile
@@ -1,5 +1,5 @@
 CXX=g++
-CXXFLAGS=-O3 -std=c++11 -g -I$(CUDA_ROOT)/include/
+CXXFLAGS=-O3 -std=c++11 -g -I$(CUDA_ROOT)/include
 LDFLAGS=-L$(CUDA_ROOT)/lib64
 LIBS=-lnvToolsExt
 SHARED_CXXFLAGS=-shared -fPIC

diff --git a/profiling/roctx-connector/CMakeLists.txt b/profiling/roctx-connector/CMakeLists.txt
@@ -3,5 +3,5 @@ find_path(ROCM_ROCTX_INCLUDE roctx.h REQUIRED HINTS $ENV{ROCM_PATH}/include/roct
 
 kp_add_library(kp_roctx_connector kp_roctx_connector.cpp)
 
-target_include_directories(kp_roctx_connector PUBLIC ${ROCM_ROCTX_INCLUDE})
-target_link_libraries(kp_roctx_connector PUBLIC ${ROCM_ROCTX_LIB})
+target_include_directories(kp_roctx_connector PRIVATE ${ROCM_ROCTX_INCLUDE})
+target_link_libraries(kp_roctx_connector PRIVATE ${ROCM_ROCTX_LIB})
diff --git a/profiling/roctx-connector/kp_roctx_connector.cpp b/profiling/roctx-connector/kp_roctx_connector.cpp
@@ -58,7 +58,6 @@ void kokkosp_init_library(const int loadSeq,
   std::cout << "-----------------------------------------------------------\n"
             << "KokkosP: ROC Tracer Connector (sequence is " << loadSeq
             << ", version: " << interfaceVer << ")\n"
-            << "Global fences: " << (tool_globfences ? "ON" : "OFF") << "\n"
             << "-----------------------------------------------------------\n";
 
   roctxMark("Kokkos::Initialization Complete");