put default types in KokkosKernels namespace #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwpearson
force-pushed
the
fix/2335
branch
2 times, most recently
from
b6fe622
to
d3b6721
Compare
|
Oh I guess we need to deprecate all these. |
cwpearson
force-pushed
the
fix/2335
branch
4 times, most recently
from
08133fb
to
408e60f
Compare
cwpearson
force-pushed
the
fix/2335
branch
2 times, most recently
from
19a21f1
to
e2b38f6
Compare
Signed-off-by: Carl Pearson <[email protected]>
Signed-off-by: Carl Pearson <[email protected]>
lucbv
approved these changes
Oct 17, 2024
| @@ -626,25 +632,30 @@ void __do_loop_and_invoke(options_t options, void (*fn)(options_t, trmm_args_t)) | |||
| /*************************** External fns **************************/ | |||
| void do_trmm_serial_blas(options_t options) { | |||
| STATUS; | |||
| __do_loop_and_invoke(options, __do_trmm_serial_blas<default_scalar, view_type_3d, view_type_3d, default_device>); | |||
| __do_loop_and_invoke( | |||
There was a problem hiding this comment.
Not for this PR but these leading double underscores are really ill advised...
There was a problem hiding this comment.
I will fix it in a future one 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves everything defined in
common/src/KokkosKernels_default_types.hppto theKokkosKernelsnamespace. The rest of the changes are just search-replace style modifications to accommodate that.Potential fix for #2335