Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maybe_unused to actually used variables #172

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau self-assigned this Oct 13, 2024
@yasahi-hpc
Copy link
Collaborator

Actually, we need them for nvcc to avoid warnings. I thought these warnings lead to the compiler errors in CI. I will fix the CI.

@tpadioleau
Copy link
Member Author

Actually, we need them for nvcc to avoid warnings. I thought these warnings lead to the compiler errors in CI. I will fix the CI.

Oh I see, let me try removing a pair of brackets

@yasahi-hpc
Copy link
Collaborator

Actually, we need them for nvcc to avoid warnings. I thought these warnings lead to the compiler errors in CI. I will fix the CI.

Oh I see, let me try removing a pair of brackets

Thanks!
For some reason, these warnings do not cause compile errors even with -Werror and -DCMAKE_COMPILE_WARNING_AS_ERROR=ON.

@yasahi-hpc yasahi-hpc merged commit 74705bb into kokkos:main Oct 14, 2024
19 of 20 checks passed
@tpadioleau tpadioleau deleted the remove-some-maybe_unused branch October 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants