Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add emitDeclarationOnly settings for typescript #236

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

MaikoTan
Copy link
Member

This is the following fixup for #234 which switch TypeScript to ESNext module causing the result to be ESM, this setting would make tsc generates definitions only, and the JS part would be built by esbuild which guarantee to be CJS.

@MaikoTan MaikoTan requested review from shigma and Lipraty July 31, 2024 05:17
@MaikoTan MaikoTan enabled auto-merge July 31, 2024 05:17
Copy link

PR Health

Build ✅

Details
esbuild: packages/core/src/index.ts -> packages/core/lib/index.js
esbuild: packages/danbooru/src/index.ts -> packages/danbooru/lib/index.js
esbuild: packages/e621/src/index.ts -> packages/e621/lib/index.js
esbuild: packages/gelbooru/src/index.ts -> packages/gelbooru/lib/index.js
esbuild: packages/konachan/src/index.ts -> packages/konachan/lib/index.js
esbuild: packages/local/src/index.ts -> packages/local/lib/index.js
esbuild: packages/lolibooru/src/index.ts -> packages/lolibooru/lib/index.js
esbuild: packages/lolicon/src/index.ts -> packages/lolicon/lib/index.js
esbuild: packages/moehu/src/index.ts -> packages/moehu/lib/index.js
esbuild: packages/pixiv/src/index.ts -> packages/pixiv/lib/index.js
esbuild: packages/safebooru/src/index.ts -> packages/safebooru/lib/index.js
esbuild: packages/sankaku/src/index.ts -> packages/sankaku/lib/index.js
esbuild: packages/yande/src/index.ts -> packages/yande/lib/index.js

Lint ✅

Details
Checking formatting...
All matched files use Prettier code style!

@MaikoTan MaikoTan added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 136fd41 Jul 31, 2024
9 checks passed
@MaikoTan MaikoTan deleted the EDO branch July 31, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants