Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): using JSX #115

Merged
merged 2 commits into from
Nov 7, 2023
Merged

refactor(core): using JSX #115

merged 2 commits into from
Nov 7, 2023

Conversation

Lipraty
Copy link
Member

@Lipraty Lipraty commented Nov 7, 2023

No description provided.

@MaikoTan
Copy link
Member

MaikoTan commented Nov 7, 2023

Really? without any changes?

At least you should refactor these lines to jsx IMO :

koishi-plugin-booru/packages/core/src/index.ts

Line 231 in f07ba50

return output.length === 1 ? output[0] : `<message forward>${output.join('\n')}</message>`

@Lipraty
Copy link
Member Author

Lipraty commented Nov 7, 2023

Really? without any changes?

At least you should refactor these lines to jsx IMO :

koishi-plugin-booru/packages/core/src/index.ts

Line 231 in f07ba50

return output.length === 1 ? output[0] : `<message forward>${output.join('\n')}</message>`

喵，忘记这里了

@MaikoTan MaikoTan added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 6ebb68e Nov 7, 2023
3 checks passed
@MaikoTan MaikoTan deleted the use-jsx branch November 7, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaikoTan MaikoTan MaikoTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lipraty @MaikoTan