-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support arbitrary search method in fast_gicp #120
Conversation
Thanks for your PR! I think this functionality is reasonable and nice. I'll take a quick look at the updates. |
CMakeLists.txt
Outdated
else() | ||
add_definitions(-msse -msse2 -msse3 -msse4 -msse4.1 -msse4.2) | ||
set(CMAKE_C_FLAGS "-msse -msse2 -msse3 -msse4 -msse4.1 -msse4.2") | ||
set(CMAKE_CXX_FLAGS "-msse -msse2 -msse3 -msse4 -msse4.1 -msse4.2") | ||
set(CMAKE_C_FLAGS "-msse -msse2 -msse3 -msse4 -msse4.1 -msse4.2 -march=native") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because PCL installed via apt-get causes segfaults with march=native
(Possibly, the CI failure is caused by this flag), I would like to make this optional like:
https://github.com/koide3/ndt_omp/blob/0852c95360d1b0d29745e7eae7a57c0950de695b/CMakeLists.txt#L7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually i think we should use PCL_DEFINITIONS
here instead of manually specifying any flags, as any PCL client project has to be compiled with the same flags to prevent such crashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added that in 672e71f
I've restored I also realized that |
… when source and target are the same
…tween PCL and fast_gicp
Co-authored-by: k.koide <[email protected]>
7c23b05
to
6122eb2
Compare
Thanks a lot for your contribution. All changes look good now. I'll merge this PR once the small conflict caused by #134 is resolved. |
Fixed. |
Thank you a lot! |
There is nothing in the code that assumes more than the
pcl::search::Search
interface of the search objects. So one might use others such asOrganizedNeighbor
which is much faster for organized clouds.The code distinguishes between source and target methods, but since
swap()
is called on their pointers, I think in practice onlyPointSource == PointTarget
is supported.