First approach for the issue #25 #26
Conversation
|
@Fairlight8 As per the discussion I would like to keep the check. This check is set in place to protect the data that should not be serialised as it is not explicitly marked as so. |
|
@dkraczkowski But this change does not remove that check you are talking about. What it is removed is that the code does not add an encode/decode scheme if it already has one. I guess that this check is there to avoid unnecessary repetitions (i.e. if a class is decorated, but also included as a member of other serializable class). As I said, I thought of an alternative solution that maintains this check. |
|
@Fairlight8 Thanks, released the fix here: https://github.com/kodemore/chili/releases/tag/2.6.0 I have added a test and a lru cache to cover your scenario. Now it should be fine. Thanks for your support. |
As mentioned in the issue #25, this is one solution to the problem. However, this change directly overrides the schema every single time. I guess that the original devs added the check
if not hasattr(cls, _PROPERTIES):for a reason.So, in conclusion, if you still want to maintain that check for efficiency, or for other reasons of the code I still don't know. I have a second solution prepared.