Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow incomplete objects to be created #24

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

dkraczkowski
Copy link
Contributor

@dkraczkowski dkraczkowski commented Aug 29, 2023

This PR changes current behaviour and disallows decoding incomplete objects unless missing properties are marked as optional with typing.Optional annotation.

@codecov-commenter
Copy link

Codecov Report

Merging #24 (bdf5643) into main (3d7001e) will decrease coverage by 0.11%.
The diff coverage is 93.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   95.30%   95.19%   -0.11%     
==========================================
  Files          39       39              
  Lines        2151     2187      +36     
==========================================
+ Hits         2050     2082      +32     
- Misses        101      105       +4     
Files Changed Coverage Δ
chili/encoder.py 93.59% <75.00%> (-0.68%) ⬇️
tests/test_decode.py 98.64% <93.54%> (-1.36%) ⬇️
chili/decoder.py 87.80% <100.00%> (+0.07%) ⬆️
chili/error.py 100.00% <100.00%> (ø)
chili/typing.py 87.60% <100.00%> (ø)
tests/usecases/dataclasses_test.py 100.00% <100.00%> (ø)
tests/usecases/decodable_test.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dkraczkowski dkraczkowski merged commit c198e11 into main Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants