Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ i18n version #11224

Merged
merged 14 commits into from
Jan 27, 2025
Merged

⬆️ i18n version #11224

merged 14 commits into from
Jan 27, 2025

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 9, 2024

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory (same as #11229 (comment)) on netlify while current build pass

@roiLeo roiLeo requested a review from a team as a code owner December 9, 2024 14:32
@roiLeo roiLeo requested review from Jarsen136 and hassnian and removed request for a team December 9, 2024 14:32
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 16434df
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67976c2141d75e00083b2b47
😎 Deploy Preview https://deploy-preview-11224--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 18, 2024

ping #11260

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff, otherwise code LGTM,

@preschian preview link also not working here , works fine locally

CleanShot 2024-12-31 at 08 54 12@2x

components/navbar/MobileLanguageOption.vue Outdated Show resolved Hide resolved
components/navbar/ProfileDropdown.vue Outdated Show resolved Hide resolved
components/common/ConnectWallet/WalletAssetMenu.vue Outdated Show resolved Hide resolved
@preschian
Copy link
Member

@preschian preview link also not working here , works fine locally

Will check, probably related to my PR here: PR #11289

I personally prefer using Cloudflare Pages instead of Netlify, since we only use Netlify for deployment previews. I also faced different errors on Netlify but not on Cloudflare Pages (ref: PR #11229 comment)

I will also check if it's possible to deploy Cloudflare Pages on forked branches or not

@dudo50 dudo50 mentioned this pull request Dec 31, 2024
16 tasks
@hassnian
Copy link
Contributor

@vikiival can we merge?

@vikiival
Copy link
Member

@roiLeo can you please resolve conflicts?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@vikiival vikiival merged commit ac6cf9b into kodadot:main Jan 27, 2025
24 of 26 checks passed
@roiLeo roiLeo deleted the chore/upgrade/i18n branch January 27, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants