refactor(frontend): rename .es6 to .js #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuukis
requested review from
bufke,
jnm,
noliveleger,
magicznyleszek and
p2edwards
as code owners
Akuukis
force-pushed
the
kalvis/es6-to-js
branch
from
8badcf5 to
f42e36c
Compare
magicznyleszek
approved these changes
Jan 31, 2025
p2edwards
reviewed
Feb 3, 2025
p2edwards
reviewed
Feb 3, 2025
p2edwards
approved these changes
Feb 3, 2025
p2edwards
added a commit
that referenced
this pull request
Feb 3, 2025
Fix broken build from merging #5453 and #5463 to main in rapid sequence. - #5453 converted some .es6 files to .ts - #5463 renamed ALL .es6 files to .js - Since #5453 was merged first, #5463's merge commit introduced duplicate .js files for the .es6 files that were already converted to .ts - CI would catch this if it had been run again on #5463 again before merging that. xref: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/npm.20build.20failing.20on.20main.2002.2F03.2F25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💭 Notes
Rename files with non-standard
*.es6extension to standard*.jsextension, so that upcoming tools like Biome can find all javascript files.All package.json scripts runs successfully, as well the website renders.
👀 Preview steps
Nothing in particular, the whole frontend should work as before.