Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NLP): 500 error when transcribing audio TASK-1485 #5455

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

Guitlle
Copy link
Contributor

@Guitlle Guitlle commented Jan 27, 2025

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Take into account subscriptions plan that are addon product type when calculating an organization plan usage limits

👀 Preview steps

  1. On a stripe and NLP-enabled instance (after setting both up, these are the guides to setup stripe and NLP), set up an account or use an existing one
  2. Purchase an addon through the UI, go to Account Settings, then to Add-Ons and select a File Storage monthly add on. Go through the test mode Stripe (use card number 4242 4242 4242 4242, and dummy data)
  3. On the KPI docker container, execute the following command to synchronize the stripe test subscription table:
    i. ./manage.py djstripe_sync_models Subscription
  4. Verify on the plans tab that the purchased add on is active
  5. Use a survey with an audio question (or create one) and make a submission with an audio file
  6. Write a manual transcription (i.e. "this is a test")
  7. Attempt to use automated translation to translate the transcription from English to another language
  8. On main, this will throw a 500. On the PR branch, the attempt should succeed.

@Guitlle Guitlle self-assigned this Jan 27, 2025
@Guitlle Guitlle force-pushed the task-1485-mt-500-error branch from 4d2c9ac to 7d96955 Compare January 27, 2025 19:29
@Guitlle Guitlle marked this pull request as ready for review January 28, 2025 17:41
@Guitlle Guitlle requested review from jamesrkiger and removed request for jnm and noliveleger January 28, 2025 17:58
Copy link
Contributor

@jamesrkiger jamesrkiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Fine to merge after that

@Guitlle Guitlle merged commit a7f786d into release/2.025.02 Jan 30, 2025
4 checks passed
@Guitlle Guitlle deleted the task-1485-mt-500-error branch January 30, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants