Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintenance function to remove old import tasks #4920

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Apr 24, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Adds maintenance task for cleaning up old import tasks.

Notes

I created a new test file for this. All other import task related tests are run in API test files and this didn't seem relevant to API testing.

Related issues

implements work from #2434

@jamesrkiger jamesrkiger requested a review from bufke April 24, 2024 13:10
Copy link
Contributor

@bufke bufke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the review of my comments

kpi/maintenance_tasks.py Outdated Show resolved Hide resolved
kpi/maintenance_tasks.py Outdated Show resolved Hide resolved
kpi/tests/test_import_tasks.py Show resolved Hide resolved
kpi/maintenance_tasks.py Outdated Show resolved Hide resolved
kpi/tests/test_import_tasks.py Outdated Show resolved Hide resolved
@jamesrkiger jamesrkiger merged commit 4340874 into beta Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants