fixup!: use django setting

kobotoolbox · Jan 28, 2025 · 14aa653 · 14aa653
1 parent 0a3357a
commit 14aa653
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/kobo/settings/base.py b/kobo/settings/base.py
@@ -864,6 +864,8 @@ def __init__(self, *args, **kwargs):
 # REMOVE the oldest if a user exceeds this many exports for a particular form
 MAXIMUM_EXPORTS_PER_USER_PER_FORM = 10
 
+MAX_RETRIES_FOR_IMPORT_EXPORT_TASK = 10
+
 # Private media file configuration
 PRIVATE_STORAGE_ROOT = os.path.join(BASE_DIR, 'media')
 PRIVATE_STORAGE_AUTH_FUNCTION = \

diff --git a/kpi/tasks.py b/kpi/tasks.py
@@ -15,12 +15,11 @@
 from kpi.models.asset import Asset
 from kpi.models.import_export_task import ImportTask, SubmissionExportTask
 
-SLEEP_TIME = 2
-RETRIES = 10
-
 
 @celery_app.task(
-    autoretry_for=(ObjectDoesNotExist,), max_retries=RETRIES, retry_backoff=True
+    autoretry_for=(ObjectDoesNotExist,),
+    max_retries=settings.MAX_RETRIES_FOR_IMPORT_EXPORT_TASK,
+    retry_backoff=True,
 )
 def import_in_background(import_task_uid):
     import_task = ImportTask.objects.get(uid=import_task_uid)
@@ -29,15 +28,19 @@ def import_in_background(import_task_uid):
 
 
 @celery_app.task(
-    autoretry_for=(ObjectDoesNotExist,), max_retries=RETRIES, retry_backoff=True
+    autoretry_for=(ObjectDoesNotExist,),
+    max_retries=settings.MAX_RETRIES_FOR_IMPORT_EXPORT_TASK,
+    retry_backoff=True,
 )
 def export_in_background(export_task_uid):
     export_task = SubmissionExportTask.objects.get(uid=export_task_uid)
     export_task.run()
 
 
 @celery_app.task(
-    autoretry_for=(ObjectDoesNotExist,), max_retries=RETRIES, retry_backoff=True
+    autoretry_for=(ObjectDoesNotExist,),
+    max_retries=settings.MAX_RETRIES_FOR_IMPORT_EXPORT_TASK,
+    retry_backoff=True,
 )
 def export_task_in_background(
     export_task_uid: str, username: str, export_task_name: str