-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop node.js 12.x, 14.x, 17.x support #1797
Drop node.js 12.x, 14.x, 17.x support #1797
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1797 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 5 5
Lines 525 525
Branches 147 147
=======================================
Hits 518 518
Misses 7 7 ☔ View full report in Codecov by Sentry. |
@3imed-jaberi can you look on it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etroynov could you please rebase!
Co-authored-by: fengmk2 <[email protected]>
Bumps [encodeurl](https://github.com/pillarjs/encodeurl) from 1.0.2 to 2.0.0. - [Release notes](https://github.com/pillarjs/encodeurl/releases) - [Commits](pillarjs/encodeurl@v1.0.2...v2.0.0) --- updated-dependencies: - dependency-name: encodeurl dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jonathanong @3imed-jaberi, done. Thanks for the help! My question is: is there an opportunity for me to join the Koa project as an active developer or maintainer? I have a lot of experience with JavaScript (over 15 years), I also work with Koa and Express every day and have a lot of free time. If there is any documentation on the joining process or something similar, could you share the link? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Why we should drop old node.js version support?
There are both pros and cons to supporting as many versions of a language as possible. However, in my subjective opinion, the pros are much less than the cons and I will try to explain it.
Pros:
Cons:
express
library which supports node.jsThat's one of the reasons why the express doesn't support
async/await
of the box ( and I'm not sure that's gonna happen in the foreseeable future );Summary
I think version 3 is a good reason to make it a practice to support only those versions that are active and regularly receive security patches.
Checklist