fix(): use defaultFlags when flags is empty #1464
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes where defaultFlags get applied. Currently it is conditioned to
config.Flagsto be empty, but that is manipulated by a previous method. That manipulation includes adding flags based on the configuration options. This makesconfig.Flagsalmost never empty, sodefaultFlagsis almost never used. The PR changes wheredefaultFlagsgets applied so it is previous to the manipulation based on command line arguments. This way if the build itself didn't specify flags, defaultFlags is used.Resolves #1450