-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Adding defmt-1.0 #909
base: main
Are you sure you want to change the base?
Conversation
ahh, changelogs. |
Not sure how to make cargo-semver-checks happy here. |
Maybe you can exclude it? |
Executing $ cargo semver-checks --exclude defmt
<...>
$ cd defmt/
$ cargo semver-checks --default-features
Parsing defmt v1.0.0-alpha (current)
Parsed [ 5.198s] (current)
Parsing defmt v0.3.10 (baseline)
Parsed [ 5.530s] (baseline)
Checking defmt v0.3.10 -> v1.0.0-alpha (major change)
Checked [ 0.000s] 0 checks: 0 pass, 94 skip
Summary no semver update required
Finished [ 10.738s] defmt
$ cd ../defmt-03
$ cargo semver-checks --default-features
Parsing defmt v0.3.100 (current)
Parsed [ 5.936s] (current)
Parsing defmt v0.3.10 (baseline)
Parsed [ 5.592s] (baseline)
Checking defmt v0.3.10 -> v0.3.100 (minor change)
Checked [ 0.006s] 87 checks: 84 pass, 3 fail, 0 warn, 7 skip
<checks all crates except the two defmt ones> This should work (not tested): diff --git a/.github/workflows/cargo-semver-check.yml b/.github/workflows/cargo-semver-check.yml
index b86b92c..0cbbf44 100644
--- a/.github/workflows/cargo-semver-check.yml
+++ b/.github/workflows/cargo-semver-check.yml
@@ -14,10 +14,20 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Semver check host crates
+ - name: Semver check host crates, except defmt
+ uses: obi1kenobi/cargo-semver-checks-action@v2
+ with:
+ exclude: defmt
+ - name: Semver check defmt v1
+ uses: obi1kenobi/cargo-semver-checks-action@v2
+ with:
+ feature-group: default-features
+ manifest-path: defmt/
+ - name: Semver check defmt v0.3
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
feature-group: default-features
+ manifest-path: defmt-03/
- name: Semver check firmware crates
uses: obi1kenobi/cargo-semver-checks-action@v2
with: |
Deploying knurling-defmt-book with Cloudflare Pages
|
f43e326
to
3ea91f5
Compare
03de6a3
to
47e5c13
Compare
Rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I am not sure if a minor version bump is necessary in defmt-semihosting
, defmt-test
, panic-probe
, but it does not hurt either.
They are major version bumps, and I did that because there is no defmt compatibility at crate this time so you don't want to pick them up by accident. |
It doesn't like having two versions of defmt, and it ignores the 'exclude' field in the workspace.
…and pub use re-exports. It's something Predrag is working on, but for now, we have to do this by hand.
47e5c13
to
9560a4c
Compare
|
Removing approval just to make sure we don't accidentally release.
Adds a defmt 0.3 proxy, and bumps most crates to 1.0.0-alpha.
Tested by patching the radio-app from the exercises to use the
defmt-0.3
folder. That seems to work.