refactor: Use d-none instead of hidden for popover (#348)

knoxville-utilities-board · Jan 31, 2025 · 64be273 · 64be273
1 parent db9af82
commit 64be273
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/apps/test-app/tests/integration/components/popover-test.gts b/apps/test-app/tests/integration/components/popover-test.gts
@@ -89,11 +89,11 @@ module('Integration | Component | popover', function (hooks) {
       </Popover>
     </template>);
 
-    assert.dom('.popover').hasClass('hidden');
+    assert.dom('.popover').hasClass('d-none');
 
     await click('button');
 
-    assert.dom('.popover').doesNotHaveClass('hidden');
+    assert.dom('.popover').doesNotHaveClass('d-none');
 
     await click('button');
 

diff --git a/apps/test-app/tests/integration/components/tooltip-test.gts b/apps/test-app/tests/integration/components/tooltip-test.gts
@@ -112,15 +112,15 @@ module('Integration | Component | tooltip', function (hooks) {
 
     await render(<template><Tooltip @onShow={{show}} @onHide={{hide}} /></template>);
 
-    assert.dom('.tooltip').hasClass('hidden');
+    assert.dom('.tooltip').hasClass('d-none');
 
     assert.step('beforeShow');
     await triggerEvent('span:has(> p)', 'mouseenter');
-    assert.dom('.tooltip').doesNotHaveClass('hidden');
+    assert.dom('.tooltip').doesNotHaveClass('d-none');
 
     assert.step('beforeHide');
     await triggerEvent('span:has(> p)', 'mouseleave');
-    assert.dom('.tooltip').hasClass('hidden');
+    assert.dom('.tooltip').hasClass('d-none');
 
     assert.verifySteps(['beforeShow', 'show', 'beforeHide', 'hide']);
   });

diff --git a/packages/ember-core/src/components/popover.gts b/packages/ember-core/src/components/popover.gts
@@ -270,7 +270,7 @@ export default class Popover extends Component<PopoverSignature> {
       <div
         id={{this.id}}
         class={{classes
-          (unless this.isShown "hidden")
+          (unless this.isShown "d-none")
           (concat "popover bs-popover-" this.adjustedSide)
         }}
         {{onInsert this.initPopover}}