feat: Adding data-test tags to sidebar item, group and side-by-side #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSenter
requested changes
Jan 6, 2025
There was a problem hiding this comment.
The standard for adding selectors to aid in testing is using the ember-test-selectors addon. You don't need to add a dependency; the consuming apps are responsible for that. Instead, prefix all selectors used explicitly for testing with data-test-.
bnhkubpublic
force-pushed
the
brian-sidebar-route
branch
from
3c1696b to
5351f11
Compare
TSenter
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to test the sidebar items easier in kub-apps-core for the new role secure project. If this isn't the right way to do it please let me know.