fix(whats-new): Allow "What's New" modal to appear #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
did-insert
modifier that thenrg-new-features
component passes to thenrg-modal
component is never attached to a DOM element, since no passed-in attributes tonrg-modal
components are used anywhere. This worked in previous Ember versions since all Ember components are wrapped in adiv
by default, which is also where attributes were placed. Therefore, the modifier was placed on thediv
wrapping the modal component; thisdiv
no longer exists.