Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whats-new): Allow "What's New" modal to appear #558

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

TSenter
Copy link
Collaborator

@TSenter TSenter commented Feb 1, 2024

The did-insert modifier that the nrg-new-features component passes to the nrg-modal component is never attached to a DOM element, since no passed-in attributes to nrg-modal components are used anywhere. This worked in previous Ember versions since all Ember components are wrapped in a div by default, which is also where attributes were placed. Therefore, the modifier was placed on the div wrapping the modal component; this div no longer exists.

@TSenter TSenter requested a review from KeithClinard February 1, 2024 21:55
@KeithClinard KeithClinard merged commit 95a75a8 into main Feb 1, 2024
10 of 15 checks passed
@KeithClinard KeithClinard deleted the senter-fix-whats-new branch February 1, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants