feat(side-by-side): Create loading component (#570)

* chore: Update lockfile version * feat(side-by-side): Create loading component * chore: Update pnpm version to 9 in CI workflows * chore: Update Node.js version to 18.x in CI workflows * chore: Update test
knoxville-utilities-board · May 9, 2024 · 747baf9 · 747baf9
1 parent 8e969c9
commit 747baf9
Show file tree

Hide file tree

Showing 9 changed files with 7,945 additions and 5,692 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,29 +19,36 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
+
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
+
       - uses: pnpm/action-setup@v2
         with:
-          version: 8
+          version: 9
           run_install: false
+
       - name: Get pnpm store directory
         shell: bash
         run: |
           echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
+
       - name: Setup pnpm cache
         uses: actions/cache@v3
         with:
           path: ${{ env.STORE_PATH }}
           key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: |
             ${{ runner.os }}-pnpm-store-
+
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile
+
       - name: Lint
         run: pnpm run lint
+
       - name: Run Tests
         run: pnpm run test:ember
 
@@ -52,26 +59,32 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
+
       - uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
+
       - uses: pnpm/action-setup@v2
         with:
-          version: 8
+          version: 9
           run_install: false
+
       - name: Get pnpm store directory
         shell: bash
         run: |
           echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
+
       - name: Setup pnpm cache
         uses: actions/cache@v3
         with:
           path: ${{ env.STORE_PATH }}
           key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: |
             ${{ runner.os }}-pnpm-store-
+
       - name: Install Dependencies
         run: pnpm install --no-lockfile
+
       - name: Run Tests
         run: pnpm run test:ember
 
@@ -96,15 +109,19 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
+
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
+
       - uses: pnpm/action-setup@v2
         with:
-          version: 8
+          version: 9
           run_install: false
+
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile
+
       - name: Run Tests
         run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
diff --git a/.github/workflows/ember.yml b/.github/workflows/ember.yml
@@ -17,12 +17,12 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
 
       - name: Setup pnpm
         uses: pnpm/action-setup@v2
         with:
-          version: 8
+          version: 9
           run_install: false
 
       - name: Get pnpm store directory
@@ -58,12 +58,12 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
 
       - name: Setup pnpm
         uses: pnpm/action-setup@v2
         with:
-          version: 8
+          version: 9
           run_install: false
 
       - name: Get pnpm store directory

diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -20,12 +20,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
 
       - name: Setup pnpm
         uses: pnpm/action-setup@v2
         with:
-          version: 8
+          version: 9
           run_install: false
 
       - name: Get pnpm store directory

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -16,11 +16,11 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8
+          version: 9
           run_install: false
 
       - name: Get pnpm store directory

diff --git a/addon/components/nrg-side-by-side/loading.hbs b/addon/components/nrg-side-by-side/loading.hbs
@@ -0,0 +1,21 @@
+<NrgSideBySide class={{@class}} ...attributes>
+  <:primary>
+    <div class="ui basic segment">
+      <NrgLoadingIndicator
+        @loading={{@loading}}
+        @centered={{@centered}}
+        @inline={{@inline}}
+        @text={{@text}}
+        @inverted={{@inverted}}
+        @indeterminate={{@indeterminate}}
+        @size={{@size}}
+      >
+        {{yield to="text"}}
+      </NrgLoadingIndicator>
+    </div>
+    {{yield to="primary"}}
+  </:primary>
+  <:secondary>
+    {{yield to="secondary"}}
+  </:secondary>
+</NrgSideBySide>
diff --git a/addon/components/nrg-side-by-side/loading.js b/addon/components/nrg-side-by-side/loading.js
@@ -0,0 +1,5 @@
+import Component from '@glimmer/component';
+import { AddNrgDeprecations } from 'ember-nrg-ui/utils/deprecation-handler';
+
+@AddNrgDeprecations()
+export default class NrgSideBySideLoadingComponent extends Component {}
diff --git a/app/components/nrg-side-by-side/loading.js b/app/components/nrg-side-by-side/loading.js
@@ -0,0 +1 @@
+export { default } from 'ember-nrg-ui/components/nrg-side-by-side/loading';
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export { default } from 'ember-nrg-ui/components/nrg-side-by-side/loading';