-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: v2 addon codemod #174
base: main
Are you sure you want to change the base?
Conversation
TODO: figure out what to do with index.js Next steps: - customize the rollup.config.js to suit your needs - audit dependencies of both the new addon and test-app - run `yarn install` - run `yarn run lint:fix` in each workspace - test your addon `cd test-app; yarn test`
Error running
|
Now stuck on |
"description": "Checkbox based toggle switch component for Ember.js", | ||
"repository": "https://github.com/knownasilya/ember-toggle", | ||
"license": "MIT", | ||
"author": "Ilya Radchenko", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs "keywords": ["ember-addon"]
here
Ok, so cached polyfil was the culprit. Now to figure out how to conditionally import styles based on config? OR maybe just instructions on how the user manually imports styles. Notes on importing css https://discord.com/channels/480462759797063690/491905849405472769/1047212748666314782 |
TODO: figure out what to do with index.js
Next steps:
yarn install
yarn run lint:fix
in each workspacecd test-app; yarn test