Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] Add image hertz converter for recording kitchen demo #195

Closed
wants to merge 2 commits into from

Conversation

tkmtnt7000
Copy link

@tkmtnt7000 tkmtnt7000 commented Apr 14, 2022

This pull request addresses the issue of the incorrect correspondence between audio and video in the recording video of kitchen demo.
Specifically in this change, the previous image topic is continued to publish until the next image topic is published to be a specific frequency.

I'm also thinking a little that it might be better to move image_hz_converter.py to something like jsk_topic_tools not only for sensor_msgs/Image but also for more general topics.

@knorth55
Copy link
Owner

@tkmtnt7000 it would be better to add this node to jsk_topic_tools, I think.
The difference between topic_tools/throttle is that this node keep the hz in stable, right?
I think for another topics, you can use AnyMsg and get_message_class.
https://github.com/jsk-ros-pkg/jsk_common/blob/30cdff0624b253d58af2b00ccdf0277cf27d9ec1/jsk_tools/src/delay_timestamp.py

@tkmtnt7000
Copy link
Author

Thank you for advice.
I'll move this node to jsk_topic_tools for another topics.

@knorth55
Copy link
Owner

@tkmtnt7000 これってマージしていいんだっけ?

@tkmtnt7000
Copy link
Author

jsk_topic_toolsに出しているknorth55/jsk_common#3
jsk-ros-pkg/jsk_common#1719
に対応させた形で出し直します..

@tkmtnt7000
Copy link
Author

Move to #205

@tkmtnt7000 tkmtnt7000 closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants