Apply Docsy updates from the upstream #226
Conversation
Improves user experience on mobile screens Signed-off-by: Takuya Noguchi <[email protected]>
|
Welcome @tnir! It looks like this is your first PR to knative/website 🎉 |
knative-prow-robot
added
the
size/XS
|
/assign @tcnghia |
|
It looks a lot better on mobile with the new smaller margin (https://deploy-preview-226--knative.netlify.app vs https://knative.dev). Thanks for the change. @abrennan89 can you please also take a look? thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tcnghia, tnir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
I dont have time to test this today but I want to add that this update also picks up the recently added "click to copy" feature too (and fixes #57). |
|
Clicking around in the staged version looks great (though ive not done it throughly). I would say the other thing to verify is that the local builds run fine too. And... Thanks @tnir ! |
|
@RichieEscarez I think the local build is validated in the workflow. Check out https://deploy-preview-226--knative.netlify.app |
|
/lgtm |
|
The localbuild.sh scripts work perfectly! @tcnghia FYI, the local build uses Hugo and the Hugo server to run similar build scripts while the preview (linked above) is built through Hugo and Netlify. In the past, these builds did not behave the same and that led to lots of issues in our site. We might be past that now and I do hope thats the case but I still like to test that before we merge since not only do some contributors regularly use the localbuild.sh scripts but also one of our bots in the knative/docs repo uses it. Thanks again @tnir |
|
Thanks @RichieEscarez for explaining! |
Improves user experience on mobile screens.
cf. google/docsy#344
Closes #224