Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Github Actions optional for eventing-istio #3846

Closed
wants to merge 1 commit into from
Closed

Make Github Actions optional for eventing-istio #3846

wants to merge 1 commit into from

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 21, 2023

PRs stuck on shellchecks on git submodules.

/assign @pierDipi

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2023
@knative-prow knative-prow bot requested review from krsna-m and upodroid June 21, 2023 09:12
pierDipi
pierDipi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@creydr creydr mentioned this pull request Jun 21, 2023
Merged
@creydr
Copy link
Member Author

creydr commented Jun 21, 2023

This repo is not used anymore. knative/infra#113

@creydr creydr closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@krsna-m krsna-m Awaiting requested review from krsna-m

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creydr @pierDipi