Fix all linter warnings

pkg/reconciler/autoscaling/kpa/kpa_test.go

@@ -1873,7 +1873,7 @@ func TestMetricsReporter(t *testing.T) {
 		metricstest.IntMetric("pending_pods", 1996, nil).WithResource(wantResource),
 		metricstest.IntMetric("terminating_pods", 1983, nil).WithResource(wantResource),
 	}
-	metricstest.AssertMetric(t, wantMetrics...)
+	assertMetric(t, wantMetrics)
 
 	// Verify `want` is ignored, when it is equal to -1.
 	pc.want = -1
@@ -1888,7 +1888,26 @@ func TestMetricsReporter(t *testing.T) {
 		metricstest.IntMetric("pending_pods", 1996, nil).WithResource(wantResource),
 		metricstest.IntMetric("terminating_pods", 1955, nil).WithResource(wantResource),
 	}
-	metricstest.AssertMetric(t, wantMetrics...)
+	assertMetric(t, wantMetrics)
+}
+
+// We don't use metricstest.AssertMetrics because it doesn't filter resources properly
+func assertMetric(t *testing.T, values []metricstest.Metric) {
+	t.Helper()
+	metricstest.EnsureRecorded()
+outer:
+	for _, v := range values {
+		metrics := metricstest.GetMetric(v.Name)
+		for _, m := range metrics {
+			if cmp.Equal(m.Resource, v.Resource) {
+				if diff := cmp.Diff(v, m); diff != "" {
+					t.Error("Wrong metric (-want +got):", diff)
+				}
+				continue outer
+			}
+		}
+		t.Fatal("unable to find metrics with name and resource", v.Name, v.Resource)
+	}
 }
 
 func TestResolveScrapeTarget(t *testing.T) {