feat: builder flag with s2i option #842
Conversation
knative-prow-robot
added
kind/enhancement
do-not-merge/work-in-progress
|
@lkingland: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
lkingland
force-pushed
the
lkingland/s2i-builder
branch
from
d220bf9
to
daf9fb6
Compare
This is known to fail CI on OS X. This commit includes the new files from runnin update-codegen.sh, but will likely fail CI requiring more manual intervention.
lkingland
force-pushed
the
lkingland/s2i-builder
branch
from
daf9fb6
to
7f65e36
Compare
| // DefaultBuilderImages for Pack builders indexed by Runtime Language | ||
| var DefaultBuilderImages = map[string]string{ | ||
| "node": "gcr.io/paketo-buildpacks/builder:base", | ||
| "go": "gcr.io/paketo-buildpacks/builder:base", |
There was a problem hiding this comment.
Will this eventually have a key for all runtimes supported by paketo?
There was a problem hiding this comment.
Yes, and more specifically for all runtimes we support. For users providing completely new runtimes/templates that we are not aware of and map here, they will need to set that value in their custom language pack's manifest.yaml
|
Closed in favor of #923 |
Changes
The default builder for Functions is Pack, with the option to specify S2I using
--builder s2i.WIP:
Currently only
--language nodeis supportedThe ability to use custom implementations of Builder in the Build command is temporarily unavailable while we consolidate the Client creation process into a single default constructor in #824 and #825.
Update 2/28: The aforementioned are now merged, so this is now dependent on #865 #868 and #869, and probably a few more.
Update 3/16: The aforementioned are now merged or closed, so this is dependent on #883
/kind enhancement