On cluster s2i build for Go (alternative version) #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now func-util image has only one command of our own -- "deploy". This commits prepares grounds for one additional command named "scaffolding". The commands will be implemented in one binary and dispatched over argv[0] using symlinks. Kinda like busybox does. Signed-off-by: Matej Vašek <[email protected]>
Added new build step in tekton pipeline that scaffolds main() for Go porject when using s2i builder. Signed-off-by: Matej Vašek <[email protected]>
This will cache dependencies between docker builds. Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
|
@matejvasek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
approved
matejvasek
requested review from
matzew,
gauron99 and
lkingland
and removed request for
nainaz and
vyasgun
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
==========================================
+ Coverage 61.22% 66.60% +5.38%
==========================================
Files 130 130
Lines 15354 11995 -3359
==========================================
- Hits 9400 7989 -1411
+ Misses 5029 3043 -1986
- Partials 925 963 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matejvasek
changed the title
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
PTAL @lkingland @matzew @gauron99 |
lkingland
approved these changes
Sep 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Sep 4, 2024
* Prepare util image to accomodate multiple cmds As of now func-util image has only one command of our own -- "deploy". This commits prepares grounds for one additional command named "scaffolding". The commands will be implemented in one binary and dispatched over argv[0] using symlinks. Kinda like busybox does. Signed-off-by: Matej Vašek <[email protected]> * Add scaffolding for on-cluster build Added new build step in tekton pipeline that scaffolds main() for Go porject when using s2i builder. Signed-off-by: Matej Vašek <[email protected]> * Better docker build caching This will cache dependencies between docker builds. Signed-off-by: Matej Vašek <[email protected]> * fixup: perms Signed-off-by: Matej Vašek <[email protected]> * fixup: remove broken check Signed-off-by: Matej Vašek <[email protected]> * fixup: remove test because of 'no space left on device' Signed-off-by: Matej Vašek <[email protected]> * Make func-util rootfull Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]>
knative-prow bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* test: adding GO s2i to e2e test suite (#2401) * Remove superfluous equals sign from envvar (#2446) * Remove superfluous equals sign from envvar Signed-off-by: Matej Vašek <[email protected]> * Update rust templates Cargo.lock Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> * allow digested images to be 'run' (#2445) * init fix Signed-off-by: gauron99 <[email protected]> * dont override direct deploy tag, more tests Signed-off-by: gauron99 <[email protected]> * fix Signed-off-by: gauron99 <[email protected]> * dont validate with tagged image, fix comment Signed-off-by: gauron99 <[email protected]> * init run fix for --image Signed-off-by: gauron99 <[email protected]> * init Signed-off-by: gauron99 <[email protected]> * int test, add valid untdigested images to run Signed-off-by: gauron99 <[email protected]> * check images passed to runner for func run command Signed-off-by: gauron99 <[email protected]> * fix build/deploy image passing bug add test Signed-off-by: gauron99 <[email protected]> * fix Signed-off-by: gauron99 <[email protected]> * remove extra printing Signed-off-by: gauron99 <[email protected]> * merge functions to digested Signed-off-by: gauron99 <[email protected]> * misspell Signed-off-by: gauron99 <[email protected]> * simplify Signed-off-by: David Fridrich <[email protected]> * quick fix Signed-off-by: David Fridrich <[email protected]> * remove prints, comment Signed-off-by: David Fridrich <[email protected]> --------- Signed-off-by: gauron99 <[email protected]> Signed-off-by: David Fridrich <[email protected]> * On cluster s2i build for Go (alternative version) (#2471) * Prepare util image to accomodate multiple cmds As of now func-util image has only one command of our own -- "deploy". This commits prepares grounds for one additional command named "scaffolding". The commands will be implemented in one binary and dispatched over argv[0] using symlinks. Kinda like busybox does. Signed-off-by: Matej Vašek <[email protected]> * Add scaffolding for on-cluster build Added new build step in tekton pipeline that scaffolds main() for Go porject when using s2i builder. Signed-off-by: Matej Vašek <[email protected]> * Better docker build caching This will cache dependencies between docker builds. Signed-off-by: Matej Vašek <[email protected]> * fixup: perms Signed-off-by: Matej Vašek <[email protected]> * fixup: remove broken check Signed-off-by: Matej Vašek <[email protected]> * fixup: remove test because of 'no space left on device' Signed-off-by: Matej Vašek <[email protected]> * Make func-util rootfull Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> * Incorporate s2i CLI into func-utils image. (#2473) Signed-off-by: Matej Vašek <[email protected]> * chore: update Quarkus platform version to 3.14.1 (#2474) Co-authored-by: Knative Automation <[email protected]> Signed-off-by: Matej Vašek <[email protected]> * chore: update Springboot platform version to 3.3.3 (#2465) Co-authored-by: Knative Automation <[email protected]> Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> Signed-off-by: gauron99 <[email protected]> Signed-off-by: David Fridrich <[email protected]> Co-authored-by: Jefferson Ramos <[email protected]> Co-authored-by: David Fridrich <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Knative Automation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is alternative version where the util image is rootfull. Since git and buildpack are already rootfull I don't see any issue with this. In addition this does not require FSGroup setting which makes it easier to port it in midstream. For OCP we would have to remove the FSGroup part in midstream patching process.
/kind enhancement
Fixes #2443