Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update setup E2E to match latest Knative release #2189

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Feb 28, 2024

Changes

  • 🧹 Update or clean up current behavior

/cc @matejvasek
/wip

Let's see if it works with current dependencies, or we need to bump those first.

Fixes #

Release Note

NONE

Copy link

knative-prow bot commented Feb 28, 2024

@dsimansk: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Update or clean up current behavior

/cc @matejvasek
/wip

Let's see if it works with current dependencies, or we need to bump those first.

/kind

Fixes #

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2024
@dsimansk dsimansk added kind/chore kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 28, 2024
local contour_version=v1.10.0
local knative_serving_version=v1.13.0
local knative_eventing_version=v1.13.0
local contour_version=v1.13.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's any benefit to test with Contour as networking-layer for Serving. I'd switch to Kourier if possible. In a follow-up PR.


# Kubernetes Version node image per Kind releases (full hash is suggested):
# https://github.com/kubernetes-sigs/kind/releases
local kind_node_version=v1.27.1@sha256:b7d12ed662b873bd8510879c1846e87c7e676a79fefc93e17b2a52989d3ff42b
local kind_node_version=v1.29.2@sha256:51a1434a5397193442f0be2a297b488b6c919ce8a3931be0ce822606ea5ca245
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's locking kind on certain kube version. But we lock kind binary on certain release version anyway. I wonder if their default isn't enough. At least for current release it matches 1.29.2.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
Copy link

knative-prow bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5081821 into knative:main Feb 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/chore kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants