Update gitignore for instanced CE module #2182
Conversation
|
@matzew: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
approved
matzew
force-pushed
the
update_gitignore
branch
from
9ee2882
to
7d655d7
Compare
Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
update_gitignore
branch
from
7d655d7
to
0f8d6c6
Compare
There was a problem hiding this comment.
I don't think we want to remove these, actually. Instead, we should probably remove the lines which ignore the go.sum from the earlier templates (pre-scaffolding), and check those sumfiles in. We can either do that here in this PR, but that's outside the scope of getting the new clodevents scaffolding from func-go in, so we could probably update this pr or replace itwith one which checks in that sumfile
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -5,6 +5,7 @@ | |||
| /templates/typescript/cloudevents/build | |||
| /templates/typescript/http/build | |||
| /templates/go/cloudevents/go.sum | |||
| /templates/go/.instanced-cloudevents/go.sum | |||
There was a problem hiding this comment.
Upon closer look, I should have said to just check in the sumfile. Line 7 here will be removed when we replace the middleware with func-go
|
/close |
|
@matzew: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
/kind
Fixes #
Release Note
Docs