Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker client dependency #1877

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🧹 Update docker, pack and s2i dependencies. This update contain fixes for issues related to Go 1.20.6.

@knative-prow
Copy link

knative-prow bot commented Jul 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 19, 2023
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@matejvasek matejvasek requested review from lance, lkingland and dsimansk and removed request for jrangelramos and nainaz July 19, 2023 03:05
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.92 🎉

Comparison is base (410f075) 62.01% compared to head (a9aba27) 62.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   62.01%   62.94%   +0.92%     
==========================================
  Files         107      107              
  Lines       13729    13733       +4     
==========================================
+ Hits         8514     8644     +130     
+ Misses       4375     4222     -153     
- Partials      840      867      +27     
Flag Coverage Δ
e2e-test 35.59% <75.00%> (+0.01%) ⬆️
e2e-test-oncluster 30.63% <25.00%> (-0.08%) ⬇️
e2e-test-oncluster-runtime 25.62% <0.00%> (?)
e2e-test-runtime-go 25.97% <12.50%> (?)
e2e-test-runtime-node 27.00% <12.50%> (?)
e2e-test-runtime-python 26.98% <12.50%> (?)
e2e-test-runtime-quarkus 27.09% <12.50%> (?)
e2e-test-runtime-springboot 26.11% <12.50%> (?)
e2e-test-runtime-typescript 27.09% <12.50%> (?)
integration-tests 51.55% <75.00%> (+2.23%) ⬆️
unit-tests-macos-latest 49.25% <37.50%> (-0.02%) ⬇️
unit-tests-ubuntu-latest ?
unit-tests-windows-latest 49.26% <37.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/docker/runner.go 67.42% <83.33%> (+0.76%) ⬆️
pkg/docker/docker_client.go 62.79% <100.00%> (ø)
pkg/docker/pusher.go 66.26% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor Author

PTAL @lance @dsimansk

@matejvasek matejvasek marked this pull request as ready for review July 19, 2023 15:58
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2023
@matejvasek
Copy link
Contributor Author

PTAL @lkingland

@dsimansk
Copy link
Contributor

@matejvasek thanks a lot for making it work with latest Go, great stuff. Looks good to me!

Adding hold for other to chime in.

/lgtm
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland lkingland removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@knative-prow knative-prow bot merged commit 5948cf4 into knative:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants