Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Fix appending SHA256 hash to image reference in ImageWithDigest #1846

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #1784

s
Fixes a bug when appending SHA256 hash to image reference

@knative-prow knative-prow bot requested review from dsimansk and rhuss July 5, 2023 19:31
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.24 🎉

Comparison is base (61179d8) 62.89% compared to head (7159e7e) 63.14%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #1846      +/-   ##
================================================
+ Coverage         62.89%   63.14%   +0.24%     
================================================
  Files                93       93              
  Lines             11972    11976       +4     
================================================
+ Hits               7530     7562      +32     
+ Misses             3754     3730      -24     
+ Partials            688      684       -4     
Flag Coverage Δ
e2e-test 38.88% <25.00%> (-0.01%) ⬇️
e2e-test-oncluster 34.66% <25.00%> (+0.02%) ⬆️
e2e-test-oncluster-runtime 29.58% <0.00%> (?)
e2e-test-runtime-go 28.29% <25.00%> (?)
e2e-test-runtime-node 29.43% <25.00%> (?)
e2e-test-runtime-python 29.43% <25.00%> (?)
e2e-test-runtime-quarkus 29.56% <25.00%> (?)
e2e-test-runtime-springboot 28.35% <25.00%> (?)
e2e-test-runtime-typescript 29.56% <25.00%> (?)
integration-tests 50.05% <25.00%> (-0.05%) ⬇️
unit-tests-macos-latest 48.93% <100.00%> (+0.04%) ⬆️
unit-tests-ubuntu-latest 49.85% <100.00%> (+0.04%) ⬆️
unit-tests-windows-latest 48.99% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/functions/function.go 78.92% <100.00%> (+0.99%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lance
Copy link
Member

lance commented Jul 5, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@lance
Copy link
Member

lance commented Jul 6, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@knative-prow knative-prow bot merged commit 5b29048 into knative:release-1.10 Jul 6, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants