Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: choosePort for host-runner #1825

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🐛 Fix choosePort() for host-runner.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 22, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +1.02 🎉

Comparison is base (8a078ce) 62.59% compared to head (7368a4b) 63.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   62.59%   63.61%   +1.02%     
==========================================
  Files         107      107              
  Lines       13645    13646       +1     
==========================================
+ Hits         8541     8681     +140     
+ Misses       4298     4140     -158     
- Partials      806      825      +19     
Flag Coverage Δ
e2e-test 35.45% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 31.33% <0.00%> (-0.10%) ⬇️
e2e-test-oncluster-runtime 26.82% <0.00%> (?)
e2e-test-runtime-go 25.67% <0.00%> (?)
e2e-test-runtime-node 26.72% <0.00%> (?)
e2e-test-runtime-python 26.72% <0.00%> (?)
e2e-test-runtime-quarkus 26.83% <0.00%> (?)
e2e-test-runtime-springboot 25.90% <0.00%> (?)
e2e-test-runtime-typescript 26.83% <0.00%> (?)
integration-tests 51.67% <0.00%> (+3.51%) ⬆️
unit-tests-macos-latest 49.54% <57.14%> (+0.02%) ⬆️
unit-tests-ubuntu-latest 50.33% <57.14%> (+0.02%) ⬆️
unit-tests-windows-latest 49.54% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/functions/runner.go 78.18% <57.14%> (+0.13%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek matejvasek requested review from lance, zroubalik and jrangelramos and removed request for navidshaikh and vyasgun June 23, 2023 19:46
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@knative-prow knative-prow bot merged commit cbd6b04 into knative:main Jun 26, 2023
@lance
Copy link
Member

lance commented Jul 5, 2023

/cherry-pick release-1.10

@knative-prow-robot
Copy link

@lance: #1825 failed to apply on top of branch "release-1.10":

Applying: fix: choosePort for host-runner
Using index info to reconstruct a base tree...
A	pkg/functions/runner.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/functions/runner.go deleted in HEAD and modified in fix: choosePort for host-runner. Version fix: choosePort for host-runner of pkg/functions/runner.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: choosePort for host-runner
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants