Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor builder concurrency test #1821

Merged

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Jun 21, 2023

  • 🧹 refactor build concurrency test

Expands the builder to include an optional notification channel such that temporary test tooling can be removed entirely from the builder core and logic kept in the test only.

/kind cleanup

@knative-prow
Copy link

knative-prow bot commented Jun 21, 2023

@lkingland: The label(s) kind/cleanuo cannot be applied, because the repository doesn't have them.

In response to this:

  • 🧹 refactor build concurrency test

/kind cleanuo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@knative-prow knative-prow bot requested review from rhuss and vyasgun June 21, 2023 06:43
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2023
@lkingland lkingland added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 77.27% and project coverage change: +1.03 🎉

Comparison is base (8dc5a76) 62.62% compared to head (cb4a6e0) 63.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1821      +/-   ##
==========================================
+ Coverage   62.62%   63.66%   +1.03%     
==========================================
  Files         106      106              
  Lines       13664    13627      -37     
==========================================
+ Hits         8557     8675     +118     
+ Misses       4301     4126     -175     
- Partials      806      826      +20     
Flag Coverage Δ
e2e-test 35.47% <0.00%> (+0.09%) ⬆️
e2e-test-oncluster 31.36% <0.00%> (+0.08%) ⬆️
e2e-test-oncluster-runtime 26.84% <0.00%> (?)
e2e-test-runtime-go 25.77% <0.00%> (?)
e2e-test-runtime-node 26.73% <0.00%> (?)
e2e-test-runtime-python 26.73% <0.00%> (?)
e2e-test-runtime-quarkus 26.85% <0.00%> (?)
e2e-test-runtime-springboot 25.91% <0.00%> (?)
e2e-test-runtime-typescript 26.85% <0.00%> (?)
integration-tests 51.70% <77.27%> (+3.45%) ⬆️
unit-tests-macos-latest 49.52% <77.27%> (-0.04%) ⬇️
unit-tests-ubuntu-latest 50.32% <77.27%> (-0.06%) ⬇️
unit-tests-windows-latest 49.53% <77.27%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/oci/containerize.go 61.37% <66.66%> (+1.72%) ⬆️
pkg/oci/builder.go 78.88% <100.00%> (+1.36%) ⬆️
pkg/oci/containerize_go.go 71.81% <100.00%> (-1.34%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lkingland lkingland marked this pull request as ready for review June 21, 2023 06:52
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@knative-prow knative-prow bot requested a review from jrangelramos June 21, 2023 06:52
@lkingland lkingland requested review from lance, salaboy, zroubalik, aslom and matejvasek and removed request for rhuss, jrangelramos and vyasgun June 21, 2023 06:53
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 278ce6b into knative:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants