Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add dapr version echo to cluster allocation output #1805

Closed
wants to merge 5 commits into from
Closed

src: add dapr version echo to cluster allocation output #1805

wants to merge 5 commits into from

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Jun 9, 2023 •
edited
Loading

  • 🧹 adds a dapr version output to cluster allocation
  • 🐛 temporarily disables Dapr installation due to installation error
  • 🧹 upgrades versions of all CI cluster dependencies

/kind cleanup

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 9, 2023
@knative-prow knative-prow bot requested review from maximilien and rhuss June 9, 2023 02:43
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 9, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +1.02 🎉

Comparison is base (8489a0d) 51.06% compared to head (69fd215) 52.08%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1805      +/-   ##
==========================================
+ Coverage   51.06%   52.08%   +1.02%     
==========================================
  Files          94       92       -2     
  Lines       12576    12347     -229     
==========================================
+ Hits         6422     6431       +9     
+ Misses       5579     5185     -394     
- Partials      575      731     +156
Flag Coverage Δ
integration-tests 52.08% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

matejvasek
matejvasek reviewed Jun 9, 2023
View reviewed changes
pkg/functions/client_int_test.go
@@ -399,6 +399,11 @@ func Handle(ctx context.Context, res http.ResponseWriter, req *http.Request) {
// TestInvoke_ServiceToService ensures that a Function can invoke another
// service via localhost service discovery api provided by the Dapr sidecar.
func TestInvoke_ServiceToService(t *testing.T) {
// Temporarily disable tests which require Dapr
// See https://github.com/knative/func/issues/1806
t.Log("TestInvoke_ServiceToService temporarily disabled as it depends on Dapr runtme which is failing to install")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The t.Skip() function is IMO more fitting.

@matejvasek
Copy link
Contributor

This probably happens because docker.io IP throttling when not logged in. I am trying to solve this with mirroring. The dapr CLI even has flags for this --image-registry too bad there is a bug in it. It applies the repository only to 4 of 5 deployments so one deployment still fails see this issue.

Now I am trying to set mirroring in KinD's containerd config.

@matejvasek
Copy link
Contributor

The dapr images are available at ghcr.io/dapr.

@matejvasek
Copy link
Contributor

#1809

@matejvasek
Copy link
Contributor

btw it looks like the error spontaneously disappeared.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lkingland
Copy link
Member Author

No longer necessary

@lkingland lkingland closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek matejvasek left review comments

@maximilien maximilien Awaiting requested review from maximilien

@rhuss rhuss Awaiting requested review from rhuss

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkingland @matejvasek @knative-prow-robot