Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S2I build with podman #1014

Merged
merged 1 commit into from
May 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions s2i/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ func (b *Builder) Build(ctx context.Context, f fn.Function) (err error) {
}
defer client.Close()

if isPodman(ctx, client) {
client = podmanDockerClient{client}
}

// Build Config
cfg := &api.Config{}
cfg.Quiet = !b.verbose
Expand Down
62 changes: 62 additions & 0 deletions s2i/docker_client_wrapper.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
package s2i

import (
"context"
"encoding/json"
"fmt"
"strings"

"github.com/docker/docker/api/types"
"github.com/docker/docker/client"
)

// Wrapper to workaround https://github.com/containers/podman/issues/13770
type podmanDockerClient struct {
client.CommonAPIClient
}

func (p podmanDockerClient) ContainerCommit(ctx context.Context, nameOrID string, opts types.ContainerCommitOptions) (types.IDResponse, error) {
if len(opts.Config.Cmd) > 0 {
bs, err := json.Marshal(opts.Config.Cmd)
if err != nil {
return types.IDResponse{}, err
}
opts.Changes = append(opts.Changes, "CMD "+string(bs))
}

if len(opts.Config.Entrypoint) > 0 {
bs, err := json.Marshal(opts.Config.Entrypoint)
if err != nil {
return types.IDResponse{}, err
}
opts.Changes = append(opts.Changes, "ENTRYPOINT "+string(bs))
}

if opts.Config.User != "" {
opts.Changes = append(opts.Changes, "USER "+opts.Config.User)
}

for _, e := range opts.Config.Env {
parts := strings.SplitN(e, "=", 2)
opts.Changes = append(opts.Changes, fmt.Sprintf("ENV %s=%q", parts[0], parts[1]))
}

for k, v := range opts.Config.Labels {
opts.Changes = append(opts.Changes, fmt.Sprintf("LABEL %q=%q", k, v))
}

return p.CommonAPIClient.ContainerCommit(ctx, nameOrID, opts)
}

func isPodman(ctx context.Context, cli client.CommonAPIClient) bool {
v, err := cli.ServerVersion(ctx)
if err != nil {
return false
}
for _, comp := range v.Components {
if comp.Name == "Podman Engine" {
return true
}
}
return false
}