Please run goimports. diff --git a/cmd/create.go b/cmd/create.go index 11da512..f308c4e 100644 --- a/cmd/create.go +++ b/cmd/create.go @@ -178,11 +178,11 @@ func newCreateConfig(cmd *cobra.Command, args []string, newClient ClientFactory) dirName string absolutePath string ) - client, done := newClient(ClientConfig{Verbose: cfg.Verbose}) + client, done := newClient(ClientConfig{Verbose: cfg.Verbose}) defer done() // IN confirm mode. If also in an interactive terminal, run prompts. - if len(args)<1 { + if len(args) < 1 { createdCfg, err := cfg.prompt(client) if err != nil { return createdCfg, err @@ -190,7 +190,7 @@ func newCreateConfig(cmd *cobra.Command, args []string, newClient ClientFactory) fmt.Println("Command:") fmt.Println(singleCommand(cmd, args, createdCfg)) return createdCfg, nil - }else { + } else { path = args[0] }

Please run goimports. diff --git a/pkg/functions/function.go b/pkg/functions/function.go index 459f8cc..dd9c587 100644 --- a/pkg/functions/function.go +++ b/pkg/functions/function.go @@ -141,7 +141,7 @@ type RunSpec struct { // Env variables to be set Envs Envs `yaml:"envs,omitempty"` - + // PodSecurityContext to be set for read and write permission PodSecurityContext PodSecurityContext `yaml:"podSecurityContext, omitempty"` // StartTimeout specifies that this function should have a custom timeout

Please run goimports. diff --git a/pkg/knative/deployer.go b/pkg/knative/deployer.go index 19e201e..84e8460 100644 --- a/pkg/knative/deployer.go +++ b/pkg/knative/deployer.go @@ -435,7 +435,7 @@ func generateNewService(f fn.Function, decorator DeployDecorator) (*v1.Service, for k, v := range annotations { revisionAnnotations[k] = v } - PodSecurityContext := getPodSecurityContext(f.Run) + PodSecurityContext := getPodSecurityContext(f.Run) service := &v1.Service{ ObjectMeta: metav1.ObjectMeta{ Name: f.Name, @@ -1077,12 +1077,12 @@ func setServiceOptions(template *v1.RevisionTemplateSpec, options fn.Options) er return servingclientlib.UpdateRevisionTemplateAnnotations(template, toUpdate, toRemove) } -func getPodSecurityContext(RunSpec fn.RunSpec) *corev1.PodSecurityContext{ - return &corev1.PodSecurityContext{ - RunAsUser: RunSpec.PodSecurityContext.RunAsUser, - RunAsGroup: RunSpec.PodSecurityContext.RunAsGroup, +func getPodSecurityContext(RunSpec fn.RunSpec) *corev1.PodSecurityContext { + return &corev1.PodSecurityContext{ + RunAsUser: RunSpec.PodSecurityContext.RunAsUser, + RunAsGroup: RunSpec.PodSecurityContext.RunAsGroup, RunAsNonRoot: RunSpec.PodSecurityContext.RunAsNonRoot, - FSGroup: RunSpec.PodSecurityContext.FSGroup, + FSGroup: RunSpec.PodSecurityContext.FSGroup, } -} \ No newline at end of file +}

Process completed with exit code 1.

[trailing whitespace] reported by reviewdog 🐶 Raw Output: pkg/functions/function.go:144:

[trailing whitespace] reported by reviewdog 🐶 Raw Output: schema/func_yaml-schema.json:373:

Process completed with exit code 1.

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: pkg/knative/deployer.go:1088: Missing newline

Process completed with exit code 1.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, actions/checkout@v3, andstor/file-existence-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Restore cache failed: Dependencies file is not found in /home/runner/work/func/func. Supported file pattern: go.sum

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Restore cache failed: Dependencies file is not found in /home/runner/work/func/func. Supported file pattern: go.sum

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, actions/checkout@v3, andstor/file-existence-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Restore cache failed: Dependencies file is not found in /home/runner/work/func/func. Supported file pattern: go.sum

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, actions/checkout@v3, andstor/file-existence-action@v1, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/