Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventshub forwarder, don't clone Host header #692

Merged
merged 1 commit into from
Mar 19, 2024
Merged

eventshub forwarder, don't clone Host header #692

merged 1 commit into from
Mar 19, 2024

Conversation

maschmid
Copy link
Contributor

  • 🧹 eventshub forwarder, don't clone the Host header of the original request

@knative-prow knative-prow bot requested review from cardil and upodroid March 18, 2024 18:00
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2024
@mgencur
Copy link
Contributor

mgencur commented Mar 19, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@knative-prow knative-prow bot merged commit 56cee28 into knative-extensions:main Mar 19, 2024
22 of 26 checks passed
@maschmid
Copy link
Contributor Author

/cherry-pick release-1.13

@maschmid
Copy link
Contributor Author

/cherry-pick release-1.12

@knative-prow-robot knative-prow-robot mentioned this pull request Mar 19, 2024
Merged
@knative-prow-robot
Copy link

@maschmid: new pull request created: #693

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link

@maschmid: new pull request created: #694

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@mgencur mgencur

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maschmid @mgencur @knative-prow-robot @creydr