-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matcher for used OIDC user name #639
Add matcher for used OIDC user name #639
Conversation
cf693f6
to
1c3c1d2
Compare
21f47e7
to
a6ddc67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small nits that I think will make it easier to debug failures when using this, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e8273a6
into
knative-extensions:main
Add a event matcher, to check the OIDC user name of the received event.
This adds two new functions:
MatchOIDCUser(username)
to directly check if the given username matches the OIDC username in EventInfoMatchOIDCUserFromResource(gvr, resourceName)
to check, if the OIDC username from the given resource matches the OIDC username in the EventInfoThis allows e.g. testcases like the following: