Flags for setting poll timeout and poll interval #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgencur: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
the
size/S
|
This will need a fix. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
* use context poll interval/timeout in DeleteResources (#626) * use context poll interval/timeout in DeleteResources * move timings to state to break dep cycle * comments * Flags for setting poll timeout and poll interval (#630) * Flags for setting poll timeout and poll interval * Rebase on latest changes when timings were moved to state package * Move setting default pollInterval and pollTimeout before applying opts --------- Co-authored-by: Marek Schmidt <[email protected]>
knative-prow bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
* use context poll interval/timeout in DeleteResources (#626) * use context poll interval/timeout in DeleteResources * move timings to state to break dep cycle * comments * Flags for setting poll timeout and poll interval (#630) * Flags for setting poll timeout and poll interval * Rebase on latest changes when timings were moved to state package * Move setting default pollInterval and pollTimeout before applying opts --------- Co-authored-by: Marek Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
poll.timeoutandpoll.intervalwhich can modify the default timeout (2m) and interval (3s). This is important for slower environments or envs with additional resources (e.g. Istio) which slow down deployments./kind
Fixes #
Release Note
Docs