Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes from traffic-isolation PoC #1099

Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Aug 30, 2023

As per discussion in #876
Fixes #876

Changes

/kind removal

Release Note

Drops the experimental `traffic-isolation` feature as this is further explored in Gateway API

Docs
None, as no docs were created yet.

@knative-prow knative-prow bot added the kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. label Aug 30, 2023
@knative-prow knative-prow bot requested review from KauzClay and skonto August 30, 2023 09:00
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2023
@ReToCode
Copy link
Member Author

/assign @nak3
/cc @dprotaso , @rhuss

@nak3
Copy link
Contributor

nak3 commented Sep 1, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@knative-prow knative-prow bot merged commit 9b26dcb into knative-extensions:main Sep 1, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for the traffic isolation feature
2 participants