Skip to content

Commit

Permalink
Fix build issues
Browse files Browse the repository at this point in the history
  • Loading branch information
norbjd authored Jun 23, 2024
1 parent c7c1285 commit 905f86e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions pkg/envoy/api/virtual_host_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
route "github.com/envoyproxy/go-control-plane/envoy/config/route/v3"
"github.com/envoyproxy/go-control-plane/pkg/wellknown"
"google.golang.org/protobuf/testing/protocmp"
"google.golang.org/protobuf/types/known/wrapperspb"
"gotest.tools/v3/assert"
)

Expand All @@ -45,7 +46,7 @@ func TestVirtualHostWithExtAuthz(t *testing.T) {
domains := []string{"foo", "bar"}
routes := []*route.Route{{Name: "baz"}}

got := NewVirtualHost(name, domains, routes, route.WithExtAuthz(nil))
got := NewVirtualHost(name, domains, routes, WithExtAuthz(nil))
want := &route.VirtualHost{
Name: name,
Domains: domains,
Expand All @@ -63,7 +64,7 @@ func TestVirtualHostWithRetryOnTransientUpstreamFailure(t *testing.T) {
domains := []string{"foo", "bar"}
routes := []*route.Route{{Name: "baz"}}

got := NewVirtualHost(name, domains, routes, route.WithRetryOnTransientUpstreamFailure())
got := NewVirtualHost(name, domains, routes, WithRetryOnTransientUpstreamFailure())
want := &route.VirtualHost{
Name: name,
Domains: domains,
Expand Down
2 changes: 1 addition & 1 deletion pkg/generator/ingress_translator.go
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func (translator *IngressTranslator) translateIngress(ctx context.Context, ingre

var virtualHost, virtualTLSHost *route.VirtualHost
// TODO(norbjd): do we want to enable this by default?
virtualHostOptions := []route.VirtualHostOption{
virtualHostOptions := []envoy.VirtualHostOption{
envoy.WithRetryOnTransientUpstreamFailure(),
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/generator/ingress_translator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ func TestIngressTranslatorHTTP01Challenge(t *testing.T) {
""),
},
route.WithRetryOnTransientUpstreamFailure(),
route.WithExtAuthz(map[string]string{"client": "kourier", "visibility": "ExternalIP"})
route.WithExtAuthz(map[string]string{"client": "kourier", "visibility": "ExternalIP"}),
),
}

Expand Down

0 comments on commit 905f86e

Please sign in to comment.