Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
upgrade to latest dependencies (#1086)
bumping golang.org/x/tools 031fc75...675bf3c:
> 675bf3c go.mod: update golang.org/x dependencies
> ad52c1c go/ssa/interp: support conversions to slices of named bytes
> 14ec3c0 gopls/doc/contributing.md: document error handling strategies
> c495364 go/packages/gopackages: document -mode flag
> 87ad891 gopls/internal/lsp/source/typerefs: move test into _test.go
> 27fd94e internal/fastwalk: doc formatting fixes (including godoc links)
> d362be0 gopls/internal/lsp/filecache: reduce GC frequency
> 969078b Revert "go/analysis: add Sizes that matches gc size computations"
> 5aa6acb go/analysis: add Sizes that matches gc size computations
> 5a89a3b go/vcs: delete
> d03a819 go/vcs: isolate into a nested module
> a659412 go/vcs: deprecate package in favor of go list -json
> 9d8d408 gopls/internal/lsp/cmd: list bug reports in 'gopls bug'
> 8f9bce4 go/ast/inspector: clarify behavior regarding comment traversal
> fa10359 gopls/internal/lsp/cache: don't panic when import fails during analysis
> c8278fe gopls/internal/lsp/cache: don't record edges to invalid packages
> 87df9bc cmd/godoc: disable TestWebIndex, a very slow test
> 63624df gopls/internal/lsp/cache: remove ITVs from shared import graph
> 0ca9d30 gopls/internal/lsp/cache: fix nil panic in analysis toSourceDiagnostic
> 85554d6 gopls/internal/lsp/cache: add debugging assertion for golang/go# 60904
> 9960b69 gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID
> 6480332 gopls/internal/lsp/cache: use types.Unsafe in analysisPackage
> 155320d gopls/internal/lsp/work: don't crash when hovering over broken mod dir
> b71392a gopls/internal/lsp/cache: reduce importing in analysis
> d1a388b internal/gcimporter: avoid a crash when exporting a struct with no pkg
> a4ed05f cmd/digraph: add "to dot" to emit Graphviz dot
> 7261b32 gopls/internal/regtest: fix goimports on windows when using vendoring
> 41e4e56 gopls/internal/lsp/source/completion: ensuring completion completeness
> ac29460 go/ssa: fix bug in writeSignature on external functions
> 3b62e7e go/ssa: use core type within (*builder).receiver
> f394d45 gopls/internal/lsp/cache: compute xrefs and methodsets asynchronously
> 27dbf85 go.mod: update golang.org/x dependencies
> c6c9830 go/types/objectpath: memoize scope lookup in objectpath.Encoder
> 0245e1d gopls/internal/regtest/codelens: set GOWORK=off for go mod vendor
> 85be888 go/analysis/passes/defers: add analyser for defer mistake
> c43232f cmd/digraph: improve examples using go list, mod
> 6e1595c internal/gcimporter: treat unknown constant values the same as invalid
> c59d87f gopls/internal/lsp/cache: two minor simplifications
> db6a81e go/packages/packagestest: set Config.Logf if the test is run verbosely
> a01290f internal/typeparams: work around LookupFieldOrMethod inconsistency
> 6f567c8 gopls/internal/lsp/filecache: reduce lifespan of os.FileInfos
> 726c727 gopls/internal/lsp: enable min/max builtin completion test
> 86c93e8 gopls: unimported completion should use the completion matcher
> 04ceacb gopls/internal/lsp/source: fix panic in typeDefinition on comparable
> 947adca gopls/internal/lsp/source/methodsets: comparable also has no package
> c35c44f gopls/internal/lsp/cache: add assertions
> 0b4461b internal/diff: fix LineEdits bug in slow path
> 1943c1e internal/diff: fix LineEdits bug in fast path
> c6d86c4 go/pointer: delete package
> 77fd064 go/types/objectpath: remove unnecessary unsafe import
> 0dda7d6 go/pointer: remove replace directive
> 98f1b4d gopls/internal/lsp/cache: check number of orphaned files after filtering
> a260315 go/pointer: create submodule
> 96844c3 cmd/{guru,callgraph}: stop using go/pointer
> cd694d8 go/packages: include "unsafe".GoFiles=["unsafe.go"]
> 33c741d gopls/internal/lsp: add min/max builtin
> 933c7cc internal/lsp/source: use exact match in import highlighting
> 5974258 gopls/internal/lsp: clear vuln diagnostics on config changes
> f3faea1 go/packages: pass -pgo=off on go1.21 and later
> 5f74ec7 internal/lsp/debug: add links to profiles and GC
> ed90c6d internal/diff: unexport various identifiers
> 827f5aa gopls/internal/lsp/source: test references bug on struct{p.T}
> a12e1a6 go/ssa/interp: implement min/max builtins
> 9c97539 gopls/internal/lsp/cache: remove nested module warning
> d44a094 gopls/internal/lsp/cmd: add a stats -anon flag to show anonymous data
> e106694 gopls/internal/lsp: bundle certain quick-fixes with their diagnostic
> 5dc3f74 gopls/internal/lsp/filecache: reenable memory cache layer
> 7e146a6 gopls/internal/lsp/cmd: simplify connection type
> 1e60668 gopls/internal/regtest/workspace: unskip duplicate modules test
> 5ce721d gopls/doc: Fix broken links
> 7a03feb gopls/internal/lsp/cmd: remove vestiges of debugging golang/go# 59475
> a70f2bc gopls/internal/regtest/misc: update and unskip TestHoverIntLiteral
> 6997d19 gopls/internal/regtest/misc: unskip TestMajorOptionsChange
> ec543c5 gopls/internal/lsp/cache: fix crash in Session.updateViewLocked
> a12ee94 gopls/internal/regtest/misc: update some unilaterally skipped tests
> 5ff5cbb gopls: deprecate support for Go 1.16 and 1.17, update warnings
> e6fd7f4 gopls/internal/lsp/cache: limit module scan to 100K files
> 9ca66ba gopls/internal/lsp/regtest: delete TestWatchReplaceTargets
> edbfdbe gopls/internal/lsp/source/completion: (unimported) add placeholders
> 3a5dbf3 gopls: add a new "subdirWatchPatterns" setting
> 3c02551 internal/typesinternal: remove NewObjectpathFunc
> 0729362 present: reformat doc comment for lack of inline code
> d4e66bd go/ssa: TestStdlib: disable check that function names are distinct
> 738ea2b go/ssa: use core type for field accesses
> 2ec4299 gopls/internal/lsp: split file-watching glob patterns
> 43b02ea gopls/internal/lsp/cache: only delete the most relevant mod tidy handle
> 5919673 internal/lsp/filecache: eliminate 'kind' directories
> a5ef6c3 gopls/internal/lsp: keep track of overlays on the files map
> d7f4359 gopls/internal/lsp/mod: optimizations for mod tidy diagnostics
> 2eb726b gopls/internal/lsp/filecache: touch only files older than 1h
> b742cb9 gopls/internal/regtest/bench: add a benchmark for diagnosing saves
> 4d66324 gopls/internal/lsp/cache: tweak error message
> e46df40 gopls/internal/lsp/filecache: delayed tweaks from code review
> 3df69b8 gopls/internal/lsp/debug: remove memory monitoring
> a069704 gopls/internal/lsp/filecache: avoid flock
> 3d53c2d gopls/internal/lsp/cache: fix race in adhoc reloading
> 8b4b27b go/analysis/passes/slog: fix Group kv offset
> 242e5ed cover: eliminate an unnecessary fsync in TestParseProfiles
> 651d951 go/ssa: fix typo in package docs
> 743372f gopls/internal/lsp/debug: limit to 100 recent trace entries
> 522243a go/ssa/interp: avoid hard-coding GOOS and GOARCH
> a059382 gopls/internal/lsp/cache: fail workspace load on context cancellation
> e5c8d4d gopls/internal/lsp/cache: unexport ValidBuildConfiguration
> f4e8a71 go/ssa: use core type for composite literal addresses
> 3b25dbd go/ssa: use core types for array length
> e7048d5 gopls/internal/lsp/filecache: front with a 100MB in-memory LRU cache
> 8c0fcd2 gopls/internal/lsp/lru: extract LRU logic to a standalone package
> 19d700c go/ssa/interp: use the actual GOOS and GOARCH to interpret tests
> 9dcd3d5 gopls/internal/lsp/filecache: limit Get parallelism too
> 7f203f0 go/ssa: consolidate use of underlying pointer
> a13793e gopls/internal/lsp: add quick-fixes to manage the go.work file
> 12a0517 internal/gcimporter: improve error handling
> 5eb1eb9 gopls/internal/lsp/cache: call filecache.Set asynchronously
> 35fe77a gopls/internal/lsp/filecache: limit parallelism in Set
> 1c9fe3f gopls: improve diagnostics for orphaned files
> ad74ff6 go/gcexportdata: drop support for the ancient binary format
> 01128f9 gopls/internal/lsp/source: fix bug renaming field to unexported
> cd39d2b internal/lsp/cache: support loading multiple orphaned files
> abeba28 gopls/internal/regtest/marker: support proxy files in marker tests
> 18186f0 go/analysis/passes/slog: simplify function matching
> 9aa9d13 cmd/bisect, internal/bisect: use more precise skip suffixes, written in hex
> 3034d9c gopls/internal/lsp/cmd: append, don't overwrite, in PublishDiagnostics
> 4318d63 gopls: change the default value of "symbolScope" to "all"
> f44f50e gopls/internal/lsp/source: implementation: report builtin 'error'
> 787e720 gopls/internal/lsp: optimize checks for ignored files
> 4ed7de1 gopls: add google-cloud-go as a benchmark repo
> d799eba gopls: additional instrumentation during goimports
> a7e7dc4 go/ssa: rename test cases in TestGenericBodies
> d668f58 gopls/internal/regtest/marker: require cgo for issue59944.txt
> 005fa64 go/analysis/passes/slog: add check for slog.Group
> 033e628 go/ssa: more reindentation of TestGenericBodies
> 2310848 go/ssa: reindent test cases in TestGenericBodies
> 90e9c65 gopls/internal/lsp/cache: skip type errors after parse errors
> 08b24db gopls/internal/lsp/regtest: check for "// @marker" rogue space
> b9c20f6 gopls/internal/regtest/marker: migrate @diag to new marker tests
> 4609d79 cmd/bisect: add -compile and -godebug shorthands
> ddfa220 internal/fuzzy: improvements to the symbol scoring algorithm
> 3449242 go/types/objectpath: don't panic when receiver is missing a method
> 0809ec2 gopls/internal/lsp/source: document {All,Workspace}Metadata
> 8f7fb01 go/analysis/unitchecker: add test of go vet on std
> 23e52a3 bisect: diagnose bad targets better
> d5af889 gopls: set GOWORK=off for loads from debug and safetoken tests
> c93329a go/analysis/passes/printf: reshorten diagnostic about %s in Println call
> 6219726 go.mod: update golang.org/x dependencies
> f4d143e go/ssa: cleanup TestGenericBodies to pickup package name
> 3d99ebe gopls/diff/unified: remove redundant information
> 479f5c6 go/ssa: Origin is only available after building
> 6d1dd12 go/analysis: simplify unusedresult
> 4a2dd0d go/callgraph/vta: allow pointer to type parameter in sliceArrayElem
> 7c6c2b7 go/ssa: keep syntax for instantiations
> ce1b96b all: fix some comments
> 0500fd4 go/ssa: use core type in address
> 8e9b185 gopls/internal/lsp/source: add the "symbolScope" option
> 4ac71c0 internal/imports: sort fixes for deterministic results
> 573915d gopls/internal/lsp/cache: always init the resolver in runProcessEnvFunc
> dd09381 bisect: move to internal/bisect until API is reviewed
> 516063a bisect, cmd/bisect: add new library and tool
> 58fedf6 internal/diffp: add patience diff from main repo
> 7b684a9 gopls: port import tests to the new marker framework
> 87974e3 gopls/internal/lsp/filecache: skip TestConcurrency on plan9 builder
> c64bb76 gopls/internal/lsp/source: make infertypeargs a convenience analyzer
> 91b7a8e go/ssa: use origin method in source lookup
> ba892bb go/types/internal/play: show formatted AST
> 7df6af8 gopls/internal/lsp/filecache: silently discard CRC errors on macOS
> 2563079 go/analysis/passes/printf: update directive diagnostic message
> 3f6c3b3 gopls: upgrade to latest version of LSP protocol
> 216928d gopls: port function extraction marker tests to the new framework
> 2415ce1 gopls: skip tests that load gopls packages if x/tools replacement is missing
> 17e5ef3 gopls/internal/lsp/cache: remove cycle check from buildMetadata
> affb5fc gopls/internal/lsp/source: fix crash in definitions of builtins
> 558d701 gopls/internal/lsp/source: fix another bug in reference expansion
> 51dfad7 gopls: port workspace/symbol marker tests to the new framework
> c6b5780 gopls: fix build at older Go versions
> 7590fe4 gopls/internal/lsp: hover over linkname directives.
> ec61ad3 gopls/internal/lsp/source: add invert-if-condition refactoring
> 5283a01 go/packages: delete TestCgoOption as it doesn't test the cgo option
> e2f3b25 gopls/internal/bug: record bug reports in file cache
> ab24b7b gopls/internal/regtest/marker: add a test case for issue # 59554
> 8235df3 gopls/internal/regtest/marker: port format tests to the new framework
> 80dc031 internal/diff: unified: match diff delete for empty file
> 165099b all: remove repeated definite articles
> ac40903 internal/gocommand: simplify GoVersion invocation
> 9e0a7b1 copyright: don't require checkout to be named tools
> 94ed378 internal/lsp/testdata: update for new diagnostic from go list
> a5c37ba gopls/internal/regtest/marker: skip on small machines
> 76e1037 internal/testenv: assume that mobile platforms are small machines
> 17e2d70 gopls/internal/bug: remove unused Data parameter
> dd89a2e gopls/internal/lsp: remove now redundant debouncing logic
> 2a9398d go/analysis/passes/slog: do not report multiple incorrect keys
> 4baa3dc gopls/internal/bug: move bug package into gopls
> 71ea8f1 go/ssa: lift structs, arrays and typeparams
> d59a28f gopls/internal/lsp/source: references: restrict search to workspace packages
> e8f417a gopls/internal/lsp/cache: cleanups to active packages
> 82c8a38 internal/gocommand: set a WaitDelay (when available) on commands
> e286d22 gopls/internal/lsp: eliminate diagnoseDetached
> 4e3238a gopls/internal/lsp/cache: break metadata cycles
> 660614b gopls/internal/lsp/source: more ITV filtering
> ce50135 go/analysis/passes/slog: static checks for slog k-v pairs
> b9619ee gopls/internal/regtest/bench: run kubernetes benchmarks with -short
> 21a4769 gopls: remove related info for informational diagnostic
> 6deeacb all: fix remaining tests on js/wasm
> bfcd41e gopls/internal/lsp/source: add missing punctuation to stubbed method doc
> 1c5ccad gopls: add a 'stats' subcommand
> 9c9e11f gopls/internal/lsp/cache: load modules by dir, not module path
> b35949e gopls/internal/lsp/source: filter intermediate test variants
> 133605d gopls/internal/lsp/cache: remove spurious error check
> 240a4dc gopls/internal/lsp/cmd: add instrumentation for TestFix
> ed3ff1b gopls/internal/lsp: finish debouncing on context cancellation
> 780626c all: fix non-gopls short tests on js/wasm and update for wasip1/wasm
> 13c52bc internal/gocommand: stop copying stdout as soon as ctx is done
> 641e4d7 gopls/doc: update coc.nvim config
> 85d651a go/analysis/checker/internal: resolve Diagnostic.URLs
> 54c806f gopls/internal/lsp: eliminate more uses of Span
> 60d9c06 go/analysis/passes: skip passes that do not import relevant packages
> 0d77eea gopls/internal/regstest/misc: use go 1.19 instead of 1.29 in TestIssue59124
> 1b2d1bd gopls/internal/lsp/cache: improve precision of cache key
> b6f4d07 gopls/internal/lsp: fix initial diagnostics pass
> d03c59d gopls/internal/lsp/source/typerefs: serialization support
> 6492058 gopls: strict LSP compliance for empty slices
> 0f415ef gopls/internal/lsp/source: support hover over non-decimal int literals
> 40fb89c internal/lsp/testdata: correct DefinitionsCount in 1.21 summary file
> a4ffa6e internal/lsp/testdata: update 'bad0' diagnostics test for 1.21
> 5bcc1bd gopls/internal/lsp/filecache: evict aggressively on Go builders
> 866a200 internal/gocommand: more tweaks to DebugHangingGoCommands
> a5338c9 go/types/objectpath: add Encoder type, to amortize Scope.Names
> 45ef829 gopls/internal/lsp/filecache: add integrity check
> 4bea115 gopls/internal/lsp/source/typerefs: collapse SCCs of ref graph
> 5ef3193 gopls/internal/lsp/source/typerefs: reexpress tests wrt ExternalRefs
> c5f768a go.mod: update golang.org/x dependencies
> 7c33a56 gopls/internal/lsp/source: show both the original declaration and the value of constants in hover
> 4d205d8 gopls/doc: add instructions for using go.work with the Go distribution
> d5076cc gopls/internal/lsp/cache: don't trace a region for MetadataForFile
> f796361 gopls/internal/lsp: add tracing instrumentation for all Server methods
> e104501 gopls/internal/astutil: TestPurgeFuncBodies requires source code for std
> 6520870 gopls/internal/lsp/source/typerefs: allow for duplicate decls
> 902fdca gopls/internal/lsp/source/typerefs: purge func bodies before parsing
> 58c9a63 go/packages/internal/nodecount: count ast.Node frequency
> 0a3e5f0 gopls: use safetoken.Line to compute line numbers
> f4e613e go/analysis/passes/tests: enable fuzz checks in 'tests' analysis pass for cmd/vet
> 6546e8e gopls/internal/lsp/source/typerefs: new package to analyze syntax deps
> 04059e1 gopls/internal/lsp/cache: record unloadable files if loading completes
> 4b11203 gopls/internal/lsp/cache: parse the builtin file through the cache
> bc35a69 gopls/internal/lsp/source: fix references expansion bug
> 374b64a go/types/internal/play: show AST debug representation too
> 13850b3 gopls/internal/lsp/regtest: move @symbol to new marker tests
> e9188f8 go/analysis/analysistest: Validate analyzers in Run
> cc511f4 gopls/internal/lsp/regtest: move @implementation to new framework
> e0ecd1b go/analysis/passes/printf: check new fmt.Appendf function too
> 488ba86 gopls/internal/lsp/cache: hold on to imports used by open packages
> d52bc56 gopls/internal/lsp: reorder the way we compute diagnostics
> 83c1ba1 gopls/internal/lsp/cache: fix two crashes when parsed file overflows
> cbe6614 go/analysis/passes/printf: improve documentation
> 255eeeb go/.../analysisutil: ExtractDoc unifies Analyzer.Doc and package doc
> 1b71eda gopls/internal/regtest/bench: add flags to reuse benchmark repo dirs
> f8a7325 gopls/internal/lsp/cache: use json encoding for diagnostics
> df92f17 gopls: pre-initialize the file cache
> c3edf5a gopls/internal/lsp/cache: actually preload files in parallel
> acaae98 gopls/internal/lsp/cache: stream package results
> fa55648 gopls/internal/lsp/cache: evaluate imports lazily in TypeCheck
> a164829 gopls/internal/lsp/cache: add additional debug assertions during parsing
> 665c922 gopls/internal/lsp/source: fix panic in quickParse
> ff76038 go/analysis/passes/printf: improve workaround doc
> b222520 gopls/internal/cache: use AddExistingFiles in the parse cache
> 6e5f425 gopls/mod: show hint for discordant module versions
> e5f7ae1 go/analysis: add Analyser.URL and Diagnostic.URI fields
> b6dbcf8 internal/gcimporter: have IImportShallow accept an import func
> 35ef64e internal/tool: add the profile.alloc flag
> 912861f gopls/internal/lsp/cache: skip object resolution during parsing
> c881168 internal/tokeninternal: add AddExistingFiles helper
> c4b943d gopls/internal/lsp: delay workspace diagnostics and analysis
> c17e55e gopls/internal/lsp/cmd: definition on items without support for hover.
> 537c4aa gopls/internal/regtest: port @refs to new marker tests
> 36ed0b1 gopls/internal/lsp/source: rename snapshot.GetFile to ReadFile
> 4feee84 go/types/internal/play: a playground for go/types
> 243a948 internal/lsp/regtest: have the regtests control their diagnosticsDelay
> ae907a4 gopls/internal/lsp/cache: pre-load files after loading packages
> 293fdc9 gopls/internal/lsp/cache: don't ignore type-errors that can't be mapped
> 6bb0e47 gopls/internal/lsp: improve concurrency of the diagnostics pass
> e4da1ee gopls/internal/lsp/debug: show log of recent spans
> dd1e2f6 cmd/present/static: fork needed godoc static resources
> 75c657b gopls/internal/regtest/bench: small fixes for DiagnoseChange
> 786752b gopls/internal/lsp/source: rename FileHandle.Read to Content
> edc0084 gopls/internal/regtest/bench: narrow the -short guard in iwl_test.go
> 656f17c gopls/internal/lsp/cache: parallelize getPackageData
> bac9896 gopls/internal/regtest/marker: add a test for golang/go# 56943
bumping knative.dev/pkg aef227e...8d3f951:
> 8d3f951 Allow overriding webhook secret data keys (# 2662)
> c11003a Use go sync/atomic instead of go.uber.org/atomic (# 2777)
> b3a65a0 Bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 (# 2775)
> e888f79 rename-sandbox (# 2779)
> 532e082 Update actions (# 2778)
> 72f2648 Bump go.uber.org/zap from 1.19.1 to 1.24.0 (# 2774)
> 7b50f3c Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 (# 2771)
> 1ea9b2d Bump github.com/tsenart/vegeta/v12 from 12.8.4 to 12.11.0 (# 2772)
> 4866914 Fix github action for dependabot (# 2776)
> edf95e6 Bump actions/setup-go from 3 to 4 (# 2770)
> 801a900 Add dependabot and auto update deps (# 2768)
> aa56e29 Update community files (# 2769)
bumping github.com/gorilla/websocket b65e629...9111bb8:
> 9111bb8 Dialer: add optional method NetDialTLSContext (# 746)
> 2f25f78 Update README (# 757)
> 4fad403 Remove support for Go 1.8
> f0643a3 Improve protocol error messages
> 2d6ee4c Update autobahn example
> beca1d3 Fix broadcast benchmarks (# 542)
> bcef843 Use context.Context in TLS handshake (# 751)
> 2c89656 Modify http Method String Literal to Variable (# 728)
> 1905f7e Update source to match output from gofmt 1.17
> b4b5d88 Document the allowed concurrency on Upgrader and Dialer (# 636)
> e8629af improve echo example (# 671)
> c3dd95a build: use build matrix; drop Go <= 1.10 (# 629)
> 78ab81e docs: clarify that sub protocols are not set via responseHeader arg.
> 873e67e Fix how the client checks for presence of Upgrade: websocket, Connection: upgrade (# 604)
bumping knative.dev/networking 75dcd54...29da3ac:
> 29da3ac rename-sandbox (# 833)
> 23adcb7 Update actions (# 832)
> 964322c Fix comment for old config (# 831)
> b13f88f Update community files (# 829)
bumping knative.dev/hack ddae802...338500e:
> 338500e Update actions (# 304)
> 6f48889 Update community files (# 303)
bumping golang.org/x/mod 69aa7ac...baa5c2d:
> baa5c2d all: add godoc links
> 7603649 zip: fix TestCreateFromDirSpecial/ignore_symlink on wasmtime
> 22d21f4 zip: fix doc for CreateFromVCS function
> bfed713 zip: fix LICENSE file handling to match modfetch
> 62c7e57 sumdb: handle panic from c.ReadRemote during ReadTiles
> 2a1c06a modfile: update toolchain syntax
> e81ad10 sumdb: correct spelling mistakes
> e343115 sumdb: add missing return after http.Error
> fc83a8f modfile: add support for dropping go and toolchain stmts
> 1846133 modfile: add parsing support for toolchain
> a73672d modfile: add support for go and toolchain lines
> e7bea8f modfile: use semantic sort for exclude blocks
> ad6fd61 zip: fix on Windows
bumping golang.org/x/sync 1ea3257...93782cc:
> 93782cc errgroup: use WithCancelCause to cancel context
> 4966af6 singleflight: example for using Group
> a6666c1 go.mod: upgrade to go 1.17
Signed-off-by: Knative Automation <[email protected]>- Loading branch information
1 parent
7340d78
commit 097eaa4