LC-605 some initial changes to the file connector to support windows mounted drive with stuff like file:///c:/foo/bar/ #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… drive with stuff like file:///c:/foo/bar/
meghanboyd
changed the title
rseitz
reviewed
Jan 13, 2025
| @@ -48,28 +48,28 @@ public interface StorageClient { | |||
| * Gets the appropriate client based on the URI scheme and validate with authentication/settings from cloudOptions | |||
| */ | |||
| static StorageClient create(URI pathToStorage, String docIdPrefix, List<Pattern> excludes, List<Pattern> includes, | |||
| Map<String, Object> cloudOptions, Config fileOptions) { | |||
| Map<String, Object> cloudOptions, Config fileOptions, Publisher publisher) { | |||
There was a problem hiding this comment.
Is this change necessary for resolving the performance issue that this PR is addressing?
There was an explicit decision during the design & review of the FileConnector framework that StorageClient should not bound to any one Publisher. A StorageClient knows about a storage backend and lets you access files from that backend. Once you have a StorageClient you can tell it to publish files with a given publisher but you shouldn't need a publisher in order to create a StorageClient. If there's a concern here, can we address this in a separate ticket/PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file connector doesn't currently work with a windows file path specified that includes the drive letter