Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e-guide.md #78

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Update e2e-guide.md #78

merged 3 commits into from
Oct 23, 2024

Conversation

noobwei
Copy link
Contributor

@noobwei noobwei commented Sep 24, 2024

No description provided.

Signed-off-by: noobwei <[email protected]>
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit 395b619
🔍 Latest deploy log https://app.netlify.com/sites/kmesh-net/deploys/67188ef4dd22e8000839eaad
😎 Deploy Preview https://deploy-preview-78--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: noobwei <[email protected]>
@kmesh-bot kmesh-bot added size/M and removed size/XS labels Oct 22, 2024
@noobwei noobwei marked this pull request as ready for review October 22, 2024 08:49
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member

defer to @YaoZengzeng

@@ -46,6 +46,16 @@ When testing locally, you may want to skip some setup steps to save time, especi
- `--skip-setup`: Skips deploying the Kubernetes cluster, Istio, and Kmesh.
- `--only-run-tests`: Skips all other steps and focuses only on deploying test applications and running E2E tests.

You might need different kinds of tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List all flags first and then explain them in the following example.

@@ -46,6 +46,16 @@ When testing locally, you may want to skip some setup steps to save time, especi
- `--skip-setup`: Skips deploying the Kubernetes cluster, Istio, and Kmesh.
- `--only-run-tests`: Skips all other steps and focuses only on deploying test applications and running E2E tests.

You might need different kinds of tests.
- `--cluster`: Allows specifying a pre-existing KinD cluster by name.
- `--ipv6`: Enables creating a KinD cluster with IPv6 networking.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `--ipv6`: Enables creating a KinD cluster with IPv6 networking.
- `--ipv6`: Enables creating a KinD cluster with IPv6 networking and run E2E tests on it.

```bash
./test/e2e/run_test.sh --cluster <KinD-Cluster-Name>
```
- Cleanup the KinD Cluster or Docker Registry After Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Cleanup the KinD Cluster or Docker Registry After Tests
- Cleanup the KinD Cluster and Docker Registry After Tests

- Selecting Specific Test Cases:

```bash
./test/e2e/run_test.sh --select-cases TestSpecificCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
./test/e2e/run_test.sh --select-cases TestSpecificCase
./test/e2e/run_test.sh --only-run-tests -run "TestServices"

--select-cases has been deleted, use go test flag directly.


```bash
./test/e2e/run_test.sh --cleanup
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add cases about ipv6 and skip-cleanup-apps

./test/e2e/run_test.sh --select-cases TestSpecificCase
```

- Controlling Test Verbosity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is tedious, maybe could add an example that show how to repeat test cases multiple times.

Signed-off-by: noobwei <[email protected]>
@YaoZengzeng
Copy link
Member

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 23, 2024
@kmesh-bot kmesh-bot merged commit 0335de8 into kmesh-net:main Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants