fix: memory leak

Closes #1227
klikli-dev · Oct 8, 2024 · dd0187b · dd0187b
1 parent 9255cf2
commit dd0187b
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/src/main/java/com/klikli_dev/occultism/integration/emi/impl/render/SpiritRenderable.java b/src/main/java/com/klikli_dev/occultism/integration/emi/impl/render/SpiritRenderable.java
@@ -7,18 +7,23 @@
 import net.minecraft.client.gui.GuiGraphics;
 import net.minecraft.world.entity.EntityType;
 
+import java.lang.ref.WeakReference;
 
-public class SpiritRenderable<T extends SpiritEntity> implements EmiRenderable{
-    T spiritEntity;
+
+public class SpiritRenderable<T extends SpiritEntity> implements EmiRenderable {
+    WeakReference<T> spiritEntity;
     EntityType<T> spiritType;
+
     public SpiritRenderable(EntityType<T> spiritType) {
-        this.spiritType=spiritType;
+        this.spiritType = spiritType;
     }
 
     @Override
     public void render(GuiGraphics draw, int x, int y, float delta) {
-        if(spiritEntity==null)
-            spiritEntity= (T) spiritType.create(Minecraft.getInstance().level);
-        SpiritGui.drawEntityToGui(draw, (int) (x+8),(int)(y+(spiritEntity.getEyeHeight()*15)+5),15,1,1,spiritEntity);
+        if (this.spiritEntity == null || this.spiritEntity.get() == null)
+            this.spiritEntity = new WeakReference(this.spiritType.create(Minecraft.getInstance().level));
+
+
+        SpiritGui.drawEntityToGui(draw, x + 8, (int) (y + (this.spiritEntity.get().getEyeHeight() * 15) + 5), 15, 1, 1, this.spiritEntity.get());
     }
 }