add get public key method for kos-web package

[pedrxlz]

Summary by CodeRabbit

• New Features
  • Added public key management for wallets
  • Introduced methods to retrieve public and private keys
• Tests
  • Enhanced test coverage for wallet creation and validation
• Improvements
  • Updated wallet struct to include public key information
  • Improved error handling for wallet operations

[coderabbitai]

Walkthrough

The changes focus on enhancing the Wallet struct in the wallet.rs file by introducing a new public_key field and associated methods. The modifications include adding methods to retrieve public and private keys, updating existing methods to set and use the public key, and expanding the test suite to validate wallet creation, key management, and error handling scenarios.

Changes

File	Changes
packages/kos-web/src/wallet.rs	- Added public_key: String field to Wallet struct - Implemented get_public_key() method - Updated from_mnemonic() and from_private_key() to set public key - Modified get_address() to use public_key.clone() - Updated test suite with new wallet functionality tests

Poem

🐰 A Wallet's Tale of Keys So Bright

Public and private, now in sight
Hex-encoded secrets, pure delight
Rust's rabbit hops with cryptic might
Keys dancing in the codebase light! 🔑

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/kos-web/src/wallet.rs (1)

325-489: LGTM! Comprehensive test coverage with clear test cases.

The test suite thoroughly covers all aspects of the wallet functionality, including error cases and cross-chain compatibility.

Consider adding a test to verify that the public key derived from a private key matches the expected value. Here's a suggested test case:

+    #[test]
+    fn test_public_key_derivation() {
+        let chain_id = 38;
+        let wallet = Wallet::from_private_key(chain_id, TEST_PRIVATE_KEY.to_string()).unwrap();
+        
+        // Verify that the derived public key matches the test constant
+        assert_eq!(wallet.get_public_key(), TEST_PUBLIC_KEY);
+        
+        // Also verify for mnemonic-derived wallet
+        let chain = get_chain_by_base_id(chain_id).unwrap();
+        let path = chain.get_path(0, false);
+        let mnemonic_wallet = Wallet::from_mnemonic(
+            chain_id,
+            TEST_MNEMONIC.to_string(),
+            path,
+            None
+        ).unwrap();
+        
+        // The mnemonic should derive to the same keypair
+        assert_eq!(mnemonic_wallet.get_public_key(), TEST_PUBLIC_KEY);
+    }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ee00db and 1e3d7cb.

📒 Files selected for processing (1)

• packages/kos-web/src/wallet.rs (7 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: format

🔇 Additional comments (3)

packages/kos-web/src/wallet.rs (3)

29-29: LGTM! Well-structured addition of the public key field.

The public_key field is appropriately placed and typed, maintaining consistency with the existing field structure.

---

92-99: LGTM! Consistent public key handling in constructors.

The public key is correctly derived and hex-encoded in both constructors, with proper error handling and memory management.

Also applies to: 141-152

---

219-224: LGTM! Well-documented getter implementation.

The get_public_key method follows the established pattern of other getters, and both methods have clear documentation about the hex encoding of returned keys.

Also applies to: 244-244