-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Android and iOS Publish action triggers #61
Conversation
WalkthroughThe changes involve updates to the GitHub Actions workflow configuration for both Android and iOS publishing. The event type that triggers these workflows has been modified from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub
participant Workflow
User->>GitHub: Create Release
GitHub-->>User: Release Created
User->>GitHub: Publish Release
GitHub-->>Workflow: Trigger Workflow
Workflow-->>User: Execute Publishing Actions
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/publish-android.yaml (1 hunks)
- .github/workflows/publish-ios.yaml (1 hunks)
Additional comments not posted (2)
.github/workflows/publish-android.yaml (1)
4-4
: LGTM!The change from
created
topublished
ensures that the workflow will only execute when a release is officially published, which aligns with the objective of improving the control flow and reliability of the deployment process..github/workflows/publish-ios.yaml (1)
4-4
: LGTM!The change from
created
topublished
ensures that the workflow will only execute when a release is officially published, which aligns with the objective of improving the control flow and reliability of the deployment process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (1)
- Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (1)
- Cargo.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/pull-master-release.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/pull-master-release.yaml (1)
81-81
: LGTM!The changes simplify the release process by automatically generating release notes and ensure the correct context by explicitly setting the target branch to
master
.
Summary by CodeRabbit
New Features
Bug Fixes
Chores