fix: foundry test #1865

unknownunknown1 · 2025-01-28T19:10:53Z

PR-Codex overview

This PR focuses on updating the KlerosCoreTest contract to use the DisputeKitClassicBase instead of DisputeKitClassic for various emitted events and imports. It also imports IArbitratorV2 from a different source.

Detailed summary

Updated imports to use IArbitratorV2 from KlerosCoreBase.sol.
Changed emitted events from DisputeKitClassic to DisputeKitClassicBase in multiple instances:
- DisputeCreation
- CommitCast
- Contribution
- ChoiceFunded
- Withdrawal
Adjusted the contract's event emissions accordingly.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Refactor
- Updated import statements for dispute kit interfaces and base classes
- Modified event emissions to reference base classes in test file

coderabbitai · 2025-01-28T19:11:02Z

Walkthrough

The changes involve modifications to the KlerosCore.t.sol test file, primarily focusing on import statements and event emissions. The modifications suggest a restructuring of the codebase, with import sources being updated and event references shifted from DisputeKitClassic to DisputeKitClassicBase. These changes appear to be part of a broader refactoring effort to consolidate and reorganize the dispute kit implementation and its associated test suite.

Changes

File	Change Summary
`contracts/test/foundry/KlerosCore.t.sol`	- Updated import statements for `IArbitratorV2` and `DisputeKitClassic` - Modified event emissions to reference `DisputeKitClassicBase` instead of `DisputeKitClassic`

Poem

🐰 In the realm of code, a rabbit's delight,
Imports shift and events take flight
From Classic to Base, a subtle dance
Refactoring magic, a testing romance
Kleros evolves with each gentle hop! 🧪

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 227337b and b6c5fb6.

📒 Files selected for processing (1)

contracts/test/foundry/KlerosCore.t.sol (8 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (15)

GitHub Check: Redirect rules - kleros-v2-testnet-devtools
GitHub Check: Redirect rules - kleros-v2-neo
GitHub Check: Header rules - kleros-v2-neo
GitHub Check: Header rules - kleros-v2-testnet-devtools
GitHub Check: Pages changed - kleros-v2-neo
GitHub Check: Pages changed - kleros-v2-testnet-devtools
GitHub Check: Redirect rules - kleros-v2-testnet
GitHub Check: Redirect rules - kleros-v2-testnet
GitHub Check: Header rules - kleros-v2-testnet
GitHub Check: Header rules - kleros-v2-testnet
GitHub Check: Pages changed - kleros-v2-testnet
GitHub Check: Pages changed - kleros-v2-testnet
GitHub Check: SonarCloud
GitHub Check: contracts-testing
GitHub Check: Analyze (javascript)

🔇 Additional comments (3)

contracts/test/foundry/KlerosCore.t.sol (3)

1330-1330: Event emission updated to use DisputeKitClassicBase.

The event emission has been correctly updated to use DisputeKitClassicBase.DisputeCreation instead of DisputeKitClassic.DisputeCreation, aligning with the architectural changes.

1596-1596: Event emissions updated to use DisputeKitClassicBase in commit tests.

Both event emissions have been correctly updated to use DisputeKitClassicBase.CommitCast instead of DisputeKitClassic.CommitCast, maintaining consistency with the architectural changes.

Also applies to: 1612-1612

2696-2696: Event emissions updated to use DisputeKitClassicBase in withdrawal tests.

Both event emissions have been correctly updated to use DisputeKitClassicBase.Withdrawal instead of DisputeKitClassic.Withdrawal, completing the migration to the new base contract.

Also applies to: 2700-2700

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-28T19:11:12Z

✅ Deploy Preview for kleros-v2-testnet ready!

Name	Link
🔨 Latest commit	`b6c5fb6`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet/deploys/67992bc01a46580008ac5faf
😎 Deploy Preview	https://deploy-preview-1865--kleros-v2-testnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-01-28T19:11:13Z

✅ Deploy Preview for kleros-v2-neo ready!

Name	Link
🔨 Latest commit	`b6c5fb6`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-neo/deploys/67992bc06c48090008485781
😎 Deploy Preview	https://deploy-preview-1865--kleros-v2-neo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-01-28T19:11:13Z

✅ Deploy Preview for kleros-v2-testnet-devtools ready!

Name	Link
🔨 Latest commit	`b6c5fb6`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/67992bc06c75120008b7cfcd
😎 Deploy Preview	https://deploy-preview-1865--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codeclimate · 2025-01-28T19:11:52Z

Code Climate has analyzed commit b6c5fb6 and detected 0 issues on this pull request.

View more on Code Climate.

sonarqubecloud · 2025-01-28T19:12:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

netlify · 2025-01-28T19:14:34Z

✅ Deploy Preview for kleros-v2-university ready!

Name	Link
🔨 Latest commit	`b6c5fb6`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/67992bc092ca8500080b257c
😎 Deploy Preview	https://deploy-preview-1865--kleros-v2-university.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

unknownunknown1 · 2025-02-01T09:11:41Z

fixed in #1872

fix: foundry test

b6c5fb6

unknownunknown1 requested a review from jaybuidl as a code owner January 28, 2025 19:10

coderabbitai bot approved these changes Jan 28, 2025

View reviewed changes

unknownunknown1 closed this Feb 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: foundry test #1865

fix: foundry test #1865

unknownunknown1 commented Jan 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 28, 2025 •

edited

Loading

netlify bot commented Jan 28, 2025 •

edited

Loading

netlify bot commented Jan 28, 2025 •

edited

Loading

codeclimate bot commented Jan 28, 2025

sonarqubecloud bot commented Jan 28, 2025

netlify bot commented Jan 28, 2025 •

edited

Loading

unknownunknown1 commented Feb 1, 2025

fix: foundry test #1865

fix: foundry test #1865

Conversation

unknownunknown1 commented Jan 28, 2025 • edited by coderabbitai bot Loading

PR-Codex overview

Detailed summary

Summary by CodeRabbit

coderabbitai bot commented Jan 28, 2025 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 28, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-testnet ready!

netlify bot commented Jan 28, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-neo ready!

netlify bot commented Jan 28, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-testnet-devtools ready!

codeclimate bot commented Jan 28, 2025

sonarqubecloud bot commented Jan 28, 2025

Quality Gate passed

netlify bot commented Jan 28, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-university ready!

unknownunknown1 commented Feb 1, 2025

unknownunknown1 commented Jan 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 28, 2025 •

edited

Loading

netlify bot commented Jan 28, 2025 •

edited

Loading

netlify bot commented Jan 28, 2025 •

edited

Loading

netlify bot commented Jan 28, 2025 •

edited

Loading