Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multiple-arbitrable-transaction): fix incompatible events #197

Merged
merged 2 commits into from
Dec 28, 2018
Merged

fix(multiple-arbitrable-transaction): fix incompatible events #197

merged 2 commits into from
Dec 28, 2018

Conversation

0xferit
Copy link
Member

@0xferit 0xferit commented Dec 26, 2018 •
edited
Loading

See #195 and #196

@0xferit 0xferit requested review from n1c01a5 and clesaege December 26, 2018 14:10
@0xferit
Copy link
Member Author

0xferit commented Dec 26, 2018

Deleted transactionID from Ruling event to be compatible with the standard. However, this can be a problem in front-end.

@0xferit 0xferit changed the title fix(multiple-arbitrable-transaction): fix #196 fix(multiple-arbitrable-transaction): fix incompatible events Dec 26, 2018
@0xferit 0xferit force-pushed the fix-multiple-arbitrable-transaction branch from 936681a to 144ffab Compare December 26, 2018 15:30
@n1c01a5 n1c01a5 merged commit c5ee106 into master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1c01a5 n1c01a5 Awaiting requested review from n1c01a5

@clesaege clesaege Awaiting requested review from clesaege

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xferit @n1c01a5